Fix Point Kinematics Reporter Variable Error

[alexbeattie42]

Brief summary of changes

Fix Point Kinematics Reporter Variable Error

Testing I've completed

Tested locally

Looking for feedback on...

CHANGELOG.md (choose one)

---

This change is 

[nickbianco]

Good find @alexbeattie42! Could you add a changelog entry, since this could affect behavior for users who might not have realized that setRelativeToBody was working incorrectly.

It would be nice to add some unittests for PointKinematics in testAnalyzeTool.cpp, if you're feeling up for it.

[alexbeattie42]

I can try to take a look at adding some test cases. I'm not very familiar with the testing framework used in the project (I believe it's catch2) but I'll give it a shot.

[nickbianco]

Thanks @alexbeattie42! Catch2 is pretty straight-forward, but let me know if you have any questions.

[alexbeattie42]

@nickbianco can you take another look?

[nickbianco]

A couple of nits, but otherwise LGTM. Nice job @alexbeattie42!

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @alexbeattie42)

---

Applications/Analyze/test/testPointKinematics.cpp line 100 at r1 (raw file):

    std::string coordinates_file_name = "subject01_walk1_ik.mot";

    OpenSim::Model model(model_name);

Minor: remove all explicit OpenSim namespace usages (here and below) since you have using namespace OpenSim above. Mostly for consistency in this file.

Suggestion:

    Model model(model_name);

---

Applications/Analyze/test/testPointKinematics.cpp line 164 at r1 (raw file):

    OpenSim::AnalyzeTool roundTrip(output_file_name);
    roundTrip.run();
    

nit: remove blank line

---

Applications/Analyze/test/testPointKinematics.cpp line 165 at r1 (raw file):

    roundTrip.run();
    
}

nit: Add newline character at EOF

[alexbeattie42]

@nickbianco Thanks! I have resolved the issues.

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @nickbianco)

[nickbianco]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alexbeattie42)

[alexbeattie42]

@nickbianco Is there anything I still need to do to get this merged?