Temporarily disable Java tests in CI #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanhab
reviewed
Jun 18, 2024
There was a problem hiding this comment.
@nickbianco I would not touch anything other than the ci build script to work around this temporary ci issue. If we disable the java build then the java tests will be skipped automatically, no reason to add any permanent changes/options to our build system.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
nickbianco
changed the title
aymanhab
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nickbianco)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily fixes #3806
Brief summary of changes
Added the CMake optionBUILD_JAVA_TESTINGto allow only disabling Java tests while configuring builds. This is primarily intended for temporarily disabiling Java tests in the Windows 2022 runner due issues as described in #3806. Accordingly, option is set tooffon that runner.After discussing with @aymanhab, we'll just disable the Java tests in the CI on Windows2022 for now.
We can create another PR renabling Java wrapping to monitor the status of the Windows2022 runners.
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is