Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop remove item #3403

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Prop remove item #3403

merged 4 commits into from
Jun 27, 2023

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Feb 20, 2023

Fixes issue #0

Brief summary of changes

Property<> is backed by a list underneath, the interface for Property allows for appending to the list, clearing the list but not removing an item from the list. For Properties used in a plugin as containers this functionality is needed.

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because not reported by user but needed by BJ Fregly's group

This change is Reviewable

@aymanhab aymanhab changed the title Prop remove value Prop remove item Jun 27, 2023
@aymanhab
Copy link
Member Author

Test failures are due to swig version that was upgraded on main

Copy link
Member

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aymanhab, just one quick suggestion for the test

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @aymanhab)


Bindings/Java/tests/TestEditProperties.java line 80 at r1 (raw file):

        assert propertyStringList.getValue(0).equals("Output0");
        propertyStringList.removeValueAtIndex(0);
        assert propertyStringList.size()==1;

Consider also adding a check that the value at 0 is now "Output2"

Copy link
Member Author

@aymanhab aymanhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @carmichaelong)


Bindings/Java/tests/TestEditProperties.java line 80 at r1 (raw file):

Previously, carmichaelong wrote…

Consider also adding a check that the value at 0 is now "Output2"

Done.

Copy link
Member

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

@carmichaelong carmichaelong merged commit ac06488 into main Jun 27, 2023
6 checks passed
@carmichaelong carmichaelong deleted the prop_remove_value branch June 27, 2023 22:56
@aymanhab
Copy link
Member Author

Thanks @carmichaelong 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants