-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prop remove item #3403
Prop remove item #3403
Conversation
Test failures are due to swig version that was upgraded on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aymanhab, just one quick suggestion for the test
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @aymanhab)
Bindings/Java/tests/TestEditProperties.java
line 80 at r1 (raw file):
assert propertyStringList.getValue(0).equals("Output0"); propertyStringList.removeValueAtIndex(0); assert propertyStringList.size()==1;
Consider also adding a check that the value at 0 is now "Output2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @carmichaelong)
Bindings/Java/tests/TestEditProperties.java
line 80 at r1 (raw file):
Previously, carmichaelong wrote…
Consider also adding a check that the value at 0 is now "Output2"
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
Thanks @carmichaelong 👍 |
Fixes issue #0
Brief summary of changes
Property<> is backed by a list underneath, the interface for Property allows for appending to the list, clearing the list but not removing an item from the list. For Properties used in a plugin as containers this functionality is needed.
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is