Fix generateDecorations of EllipsoidJoint #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d attach to correct Body instead of Ground
…d attach to correct Body instead of Ground
…m/opensim-org/opensim-core into fix_ellipsoidal_joint_decorations
improve language
|
Seems simple enough. If you need a reviewer, then LGTM. I'm guessing this was tested by just visually inspecting it in the UI? Probably good enough for this kind of thing. |
|
Indeed this was tested visually. Thanks for the review @adamkewley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue gui 1178:
opensim-org/opensim-gui#1178
Brief summary of changes
Make generateDecorations method handles fixed flag correctly and attaches to correct Body instead of Ground
Testing I've completed
loaded model in issue and moved coordinate slider and the visualization moved.
Looking for feedback on...
CHANGELOG.md (choose one)
This change is