Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review code in cmd/sti/main.go#newCmdBuild to extract what might be useful to have in origin. #206

Closed
soltysh opened this issue May 29, 2015 · 2 comments
Closed

Review code in cmd/sti/main.go#newCmdBuild to extract what might be useful to have in origin. #206

soltysh opened this issue May 29, 2015 · 2 comments
Assignees
@coreydaley
Labels
priority/P3

Comments

@soltysh
Copy link
Contributor

soltysh commented May 29, 2015

Per this comment, we should review the code in cmd/sti/main.go#newCmdBuild and extract as much as we can from there into separate package that we'll be able to reduce the amount of duplication in code in S2I and origin.
@soltysh soltysh mentioned this issue May 29, 2015
Merged
@soltysh soltysh mentioned this issue Jul 28, 2015
Merged
@bparees bparees assigned coreydaley and unassigned rhcarvalho Jun 23, 2017
@coreydaley coreydaley mentioned this issue Jul 6, 2017
Merged
@coreydaley
Copy link
Member

@bparees
The only code that I see in newCmdBuild that MIGHT be useful to factor out into something reusable is https://github.com/openshift/source-to-image/blob/master/pkg/cmd/cli/cmd/build.go#L100-L123

So, with that being said:

  • Do you see other code that would be useful?
  • Is it worth it?
  • Is this github issue still relevant?

@bparees
Copy link
Contributor

bparees commented Jan 12, 2018

not worth it.

@bparees bparees closed this as completed Jan 12, 2018
sayan-biswas added a commit to sayan-biswas/openshift-source-to-image that referenced this issue Jan 21, 2025
@sayan-biswas
Merge pull request openshift#206 from openshift/renovate/builds-1.1-r…
4977b6d 
…egistry.access.redhat.com-ubi9-go-toolset-1.x

Update registry.access.redhat.com/ubi9/go-toolset Docker tag to v1.21.11-7 (builds-1.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreydaley coreydaley

Labels
priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rhcarvalho @soltysh @bparees @coreydaley