Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-2000: Drop some unused metrics and massively speed up startup #2324

Merged

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Feb 6, 2025

Only one of these install metrics was in use by single node and they can
live without it. (confirmed)

Disruption vs two weeks ago was never used. VS ga remains.

Several other experiments are removed as well.

Only one of these install metrics was in use by single node and they can
live without it. (confirmed)

Disruption vs two weeks ago was never used. VS ga remains.

Several other experiments are removed as well.
@openshift-ci openshift-ci bot requested review from deads2k and stbenjam February 6, 2025 22:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@dgoodwin dgoodwin changed the title Drop some unused metrics and massively speed up startup TRT-2000: Drop some unused metrics and massively speed up startup Feb 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025

@dgoodwin: This pull request references TRT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Only one of these install metrics was in use by single node and they can
live without it. (confirmed)

Disruption vs two weeks ago was never used. VS ga remains.

Several other experiments are removed as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Contributor

neisw commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 96ca871 into openshift:master Feb 7, 2025
7 checks passed
@dgoodwin dgoodwin deleted the drop-unused-expensive-metrics branch February 10, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants