-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression allowance for OLMv1 #2316
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e6318f7
to
85a4352
Compare
Note, we are holding for an update in Sippy to honor the allowed regressions for new tests. Shouldn't impact this pr but fyi. |
85a4352
to
05cb64b
Compare
This may not be necessary, as we committed some fixes that should resolve (and help debug if needed) the problem we were having. |
@tmshort: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OLMv1 is new in 4.18. we are experiencing flakiness in the some tests that we may have resolved, or at least, have added code to improve logging.