Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression allowance for OLMv1 #2316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmshort
Copy link

@tmshort tmshort commented Feb 5, 2025

OLMv1 is new in 4.18. we are experiencing flakiness in the some tests that we may have resolved, or at least, have added code to improve logging.

@openshift-ci openshift-ci bot requested review from deads2k and nstielau February 5, 2025 20:03
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmshort
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort tmshort force-pushed the olm-regression branch 4 times, most recently from e6318f7 to 85a4352 Compare February 5, 2025 21:54
@neisw
Copy link
Contributor

neisw commented Feb 6, 2025

Note, we are holding for an update in Sippy to honor the allowed regressions for new tests. Shouldn't impact this pr but fyi.

@tmshort
Copy link
Author

tmshort commented Feb 6, 2025

This may not be necessary, as we committed some fixes that should resolve (and help debug if needed) the problem we were having.

Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants