Skip to content

Commit

Permalink
Remove colors from feature gate table
Browse files Browse the repository at this point in the history
Colorization was originally based on "is there enough tests" (e.g. at
least 5), but it is being mistaken as "this feature gate is passing
tests and is good."

This removes the colors.
  • Loading branch information
stbenjam committed Feb 5, 2025
1 parent 7f85d77 commit 52781f8
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions sippy-ng/src/tests/FeatureGates.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { Container, Typography } from '@mui/material'
import { DataGrid } from '@mui/x-data-grid'
import { FEATURE_GATE_TEST_THRESHOLDS } from '../constants'
import { generateClasses } from '../datagrid/utils'
import { Link, useHistory } from 'react-router-dom'
import { pathForTestSubstringByVariant, SafeJSONParam } from '../helpers'
import { useQueryParam, withDefault } from 'use-query-params'
import { withStyles } from '@mui/styles'
import Alert from '@mui/material/Alert'
import GridToolbar from '../datagrid/GridToolbar'
import PropTypes from 'prop-types'
Expand All @@ -15,7 +12,7 @@ import SimpleBreadcrumbs from '../components/SimpleBreadcrumbs'
/**
* Feature gates is the landing page for feature gates.
*/
function FeatureGates(props) {
export default function FeatureGates(props) {
const history = useHistory()

const { classes } = props
Expand Down Expand Up @@ -134,9 +131,6 @@ function FeatureGates(props) {
columns={columns}
pageSize={25}
autoHeight={true}
getRowClassName={(params) =>
classes['row-percent-' + Math.round(params.row.unique_test_count)]
}
rowsPerPageOptions={[10, 25, 50]}
sortModel={sortModel} // Controlled sortModel
onSortModelChange={(newModel) => setSortModel(newModel)}
Expand Down Expand Up @@ -170,7 +164,3 @@ FeatureGates.propTypes = {
classes: PropTypes.object,
release: PropTypes.string.isRequired,
}

export default withStyles(generateClasses(FEATURE_GATE_TEST_THRESHOLDS))(
FeatureGates
)

0 comments on commit 52781f8

Please sign in to comment.