Track files generated by make bundle
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the files generated by `make manifests` : config/crd/bases/kataconfiguration.openshift.io_kataconfigs.yaml config/rbac/role.yaml config/webhook/manifests.yaml and `make bundle` : bundle/ bundle.Dockerfile This will ease Operator SDK upgrades. Since the bundle is now tracked in the repo, the `bundle-custom.Dockerfile` file isn't needed anymore by CI. Drop it. Signed-off-by: Greg Kurz <groug@kaod.org>
|
/retest |
1 similar comment
|
/retest |
|
@gkurz I think we can merge this. I think the prow check failure is due to us pulling the latest envtest which needs golang 1.22. In my PR with Makefile changes, the envtest version is pinned and not using latest. |
|
@gkurz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the files generated by
make manifests:config/crd/bases/kataconfiguration.openshift.io_kataconfigs.yaml
config/rbac/role.yaml
config/webhook/manifests.yaml
and
make bundle:bundle/
bundle.Dockerfile
This will ease Operator SDK upgrades.
Since the bundle is now tracked in the repo, the
bundle-custom.Dockerfilefile isn't needed anymore by CI. Drop it.- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog