Add support to use pre-built pod VM image for Azure #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes shellcheck warnigns related to quotes, variable misspelling etc Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
snir911
reviewed
Sep 17, 2024
bpradipt
force-pushed
the
raw-image
branch
4 times, most recently
from
f96c565 to
ba9f985
Compare
Allows creating image version from pre-built qcow2/raw/vhd image. The pre-built image is available in a container image and the details needs to be specified in PODVM_IMAGE_URI in azure-podvm-image-cm.yaml. Azure accepts 1MB aligned VHD image only, so a qcow2 or raw will be converted to the same before uploading. qemu-img is used for the conversion. eg: oci::quay.io/openshift_sandboxed_containers/azure-podvm-image:latest::/image/podvm.vhd oci::quay.io/openshift_sandboxed_containers/azure-podvm-image:latest::/podvm.qcow2 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com> podvm-builder: Add qemu-img package qemu-img will be used to verify the pre-built image as well as convert it to different format as needed Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@bpradipt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
snir911
reviewed
Sep 19, 2024
snir911
approved these changes
Sep 19, 2024
littlejawa
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.