Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mount points #438

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Remove mount points #438

merged 2 commits into from
Jul 29, 2024

Conversation

bpradipt
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
Copy link

openshift-ci bot commented Jul 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bpradipt bpradipt marked this pull request as ready for review July 19, 2024 13:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
@bpradipt bpradipt requested review from snir911 and gkurz July 19, 2024 13:37
@openshift-ci openshift-ci bot requested review from jensfr and littlejawa July 19, 2024 13:38
config/peerpods/podvm/lib.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/lib.sh Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2024
@bpradipt bpradipt force-pushed the remove-mount branch 2 times, most recently from 1870d28 to 550f10a Compare July 27, 2024 14:21
config/peerpods/podvm/lib.sh Show resolved Hide resolved
config/peerpods/podvm/lib.sh Show resolved Hide resolved
bpradipt added 2 commits July 29, 2024 12:56
For CoCo, we don't want root disk to be used without encryption or
integrity protection. However till we have root disk encryption or
integrity protection support, let's at least ensure that overlay (rw)
directory for container image is in memory.  The container image layers
will still be downloaded to disk, however the writeable layer will be in
memory when CONFIDENTIAL_COMPUTE_ENABLED=yes.

Note that this means you'll need to have sufficient VM memory depending
on the amount of writes you expect your workload to perform

Fixes: #KATA-3229

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Ref: https://www.shellcheck.net/wiki/SC2086

Avoid using $? directly in the if statement. Fix ShellCheck SC2181 error

Ref: https://www.shellcheck.net/wiki/SC2181

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt bpradipt requested a review from snir911 July 29, 2024 07:27
Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@bpradipt bpradipt merged commit 194fede into openshift:devel Jul 29, 2024
2 of 4 checks passed
@bpradipt bpradipt deleted the remove-mount branch July 29, 2024 08:02
Copy link

openshift-ci bot commented Jul 29, 2024

@bpradipt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 13ec28a link false /test check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants