-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mount points #438
Remove mount points #438
Conversation
Skipping CI for Draft Pull Request. |
1870d28
to
550f10a
Compare
For CoCo, we don't want root disk to be used without encryption or integrity protection. However till we have root disk encryption or integrity protection support, let's at least ensure that overlay (rw) directory for container image is in memory. The container image layers will still be downloaded to disk, however the writeable layer will be in memory when CONFIDENTIAL_COMPUTE_ENABLED=yes. Note that this means you'll need to have sufficient VM memory depending on the amount of writes you expect your workload to perform Fixes: #KATA-3229 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Ref: https://www.shellcheck.net/wiki/SC2086 Avoid using $? directly in the if statement. Fix ShellCheck SC2181 error Ref: https://www.shellcheck.net/wiki/SC2181 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks
@bpradipt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.