Embed pause image #424
Merged
Embed pause image #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both these packages are needed for downloading and embedding container images in the podvm image Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@savitaashture fyi |
bpradipt
force-pushed
the
embed-pause
branch
2 times, most recently
from
d2fa672 to
e2c89a3
Compare
snir911
reviewed
Jul 1, 2024
snir911
approved these changes
Jul 3, 2024
Downloads the pause image using skopeo and uses umoci to create the oci bundle for embedding The following OCP pause image is embedded by default quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:7f3cb6f9d265291b47a7491c2ba4f4dd0752a18b661eee40584f9a5dbcbe13bb A new bash method download_and_extract_pause_image is introduced which accepts three parameters via env variable: PAUSE_IMAGE_REPO, PAUSE_IMAGE_VERSION and PAUSE_IMAGE_REPO_AUTH_FILE These can be set in the respective podvm image configMap (<provider>-podvm-image-cm.yaml) before kickstarting the pod vm image generation if required. The PAUSE_IMAGE_REPO_AUTH_FILE points to a json file containing the registry secret to pull the image from authenticated registry. The default is the cluster secret that is mounted as a volume in the `/tmp/regauth/auth.json` for osc-podvm-create-job.yaml to download OCP pause image. Fixes: #KATA-3156 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
The upstream code layout changed from src/cloud-api-adaptor to src/cloud-api-adaptor/src/cloud-api-adaptor. Accordingly change the handling of source code directory. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Latest stable image with security fixes Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
cloud-api-adaptor uses kata/main now. So update the labels to reflect the current versions of kata used with CAA Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
When RELATED_IMAGE_PODVM_PAYLOAD is set, update the job spec to use this image in initContainer. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
|
@bpradipt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Tested with custom operator and podvm-builder image to generate a podvm image with embedded pause image in Azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.