Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libvirt podvm image support #421

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add libvirt podvm image support #421

merged 1 commit into from
Jul 22, 2024

Conversation

supritai
Copy link
Contributor

@supritai supritai commented Jun 11, 2024 •
edited
Loading

- Description of the problem which is fixed/What is the use case
Add libvirt image creation job and libvirt image type for image generation.

- What I did

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 11, 2024

Hi @supritai. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

supritai
supritai commented Jun 11, 2024
View reviewed changes
config/peerpods/podvm/Dockerfile.podvm-builder Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-cm.yaml Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/osc-podvm-create-job.yaml Outdated Show resolved Hide resolved
config/peerpods/podvm/osc-podvm-create-job.yaml Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2024
@supritai55
Copy link

This PR is ready for review. Since I do not have write access, unable to remove the 'draft' tag. Can someone remove this tag please?

@jensfr jensfr removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
@bpradipt
Copy link
Contributor

bpradipt commented Jul 3, 2024

This PR is ready for review. Since I do not have write access, unable to remove the 'draft' tag. Can someone remove this tag please?

Since you are the PR creator, you should be able to change this "Ready". I believe you raised this PR as a draft pull request.

@bpradipt bpradipt marked this pull request as ready for review July 3, 2024 10:33
@openshift-ci openshift-ci bot requested review from bpradipt and snir911 July 3, 2024 10:33
@bpradipt
Copy link
Contributor

bpradipt commented Jul 4, 2024

@supritai @savitrilh can you please rebase the PR..

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 4, 2024
@supritai55
Copy link

@supritai @savitrilh can you please rebase the PR..

Sure @bpradipt

snir911
snir911 reviewed Jul 9, 2024
View reviewed changes
config/peerpods/podvm/libvirt-podvm-image-cm.yaml Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-cm.yaml Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/Dockerfile.podvm-builder Outdated Show resolved Hide resolved
@snir911
Copy link
Contributor

snir911 commented Jul 9, 2024

Thanks! I like the idea, added few comments

@bpradipt
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2024
bpradipt
bpradipt reviewed Jul 18, 2024
View reviewed changes
controllers/utils.go Outdated Show resolved Hide resolved
@bpradipt
Copy link
Contributor

@supritai once you have resolved a specific comment, can you please click on the associated "Resolve conversation" button, so that it's evident which comments have been addressed and what is still pending.

@supritai
Copy link
Contributor Author

@supritai once you have resolved a specific comment, can you please click on the associated "Resolve conversation" button, so that it's evident which comments have been addressed and what is still pending.

Sure @bpradipt , most of them I have marked as resolved. Only where agreement of reviewer needed are not closed

@bpradipt
Copy link
Contributor

Thanks @supritai for addressing the comments.
I added a minor suggestion to incorporate. In case you have tried the latest code on s390x, can you post the test results.

@bpradipt bpradipt requested a review from snir911 July 19, 2024 15:44
snir911
snir911 reviewed Jul 21, 2024
View reviewed changes
Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minor comments, overall LGTM

config/peerpods/podvm/osc-podvm-delete-job.yaml Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
@supritai
Add libvirt provider support for image building
cae12b9 
Added a new handler for libvirt to build the qcow2 image.
New ConfigMap added for libvirt specific data.
Modified the podvm create job to accomodate libvirt as well.
Added required changes for the image_generator controller.

Signed-off-by: Suprit-Iti <suprit.iti@ibm.com>
supritai
supritai commented Jul 22, 2024
View reviewed changes
Copy link
Contributor Author

@supritai supritai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attached the logs.
osc-podvm-image-creation.log
osc-podvm-image-deletion.log

config/peerpods/podvm/lib.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/osc-podvm-delete-job.yaml Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
config/peerpods/podvm/libvirt-podvm-image-handler.sh Outdated Show resolved Hide resolved
bpradipt
bpradipt approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @supritai

@bpradipt bpradipt requested a review from snir911 July 22, 2024 09:22
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
snir911
snir911 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 22, 2024

@supritai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e cae12b9 link false /test sandboxed-containers-operator-e2e
ci/prow/check cae12b9 link false /test check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@snir911 snir911 merged commit 6721043 into openshift:devel Jul 22, 2024
2 of 4 checks passed
@snir911 snir911 mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supritai55 supritai55 supritai55 left review comments

@savitrilh savitrilh savitrilh approved these changes

@snir911 snir911 snir911 approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees

@bpradipt bpradipt

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@supritai @supritai55 @bpradipt @snir911 @gkurz @savitrilh @jensfr @openshift-merge-robot