Pod VM image handling fix #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snir911
reviewed
May 12, 2024
snir911
reviewed
May 13, 2024
gkurz
reviewed
May 13, 2024
bpradipt
force-pushed
the
pvm-img-fix
branch
4 times, most recently
from
0bf96ae to
2627806
Compare
bpradipt
force-pushed
the
pvm-img-fix
branch
2 times, most recently
from
11584a6 to
fe5b4f0
Compare
gkurz
reviewed
May 15, 2024
gkurz
reviewed
May 28, 2024
gkurz
reviewed
May 29, 2024
gkurz
reviewed
May 29, 2024
gkurz
reviewed
May 29, 2024
gkurz
reviewed
May 29, 2024
gkurz
reviewed
May 29, 2024
gkurz
reviewed
May 29, 2024
If IMAGE_GALLERY_NAME in azure-podvm-image-cm is empty, then a gallery name will be created with the pattern "PodVMGallery_$clusterid. Note that only the first 8 chars of the clusterid is used. IMAGE_GALLERY_NAME annotation is added to peer-pods-cm configMap if gallery is created by OSC job FIXES: #KATA-2958 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
bpradipt
force-pushed
the
pvm-img-fix
branch
2 times, most recently
from
1cedd03 to
b884377
Compare
gkurz
reviewed
May 29, 2024
PodVM image deletion function has been extended to also support deletion of gallery via a CLI option. This is used by OSC to ensure deletion of the OSC created gallery during podvm image deletion. This ensures if gallery is created as part of kataconfig creation, then the same gallery is deleted as well during kataconfig deletion Fixes: #KATA-2958 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
az cli doesn't delete image with version ids using the az image delete command. Instead we need to use az sig image-version delete command for sig images. Ref: https://learn.microsoft.com/en-us/cli/azure/sig/image-version?view=azure-cli-latest#az-sig-image-version-delete Fixes: #KATA-2962 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This is not used anywhere Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
|
@bpradipt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #KATA-2958 #KATA-2962