1.6 bump #385
Merged
1.6 bump #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix reading of required attributes from secret and configmap 2. Refactor code for better readibility and modularity 3. Add event notification to indicate the status of the job 4. Improve job status evaluation 5. Convert image generator instance to singleton Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
The event "reason" code is used as the cache key. The default time for suppressing the event having the same reason code is 2 min. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Move the podvm image creation post kata installation. Otherwise the kata installation remains stuck with no indication on what is happening Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
There are cloud provider specific handler scripts for image creation and deletion. Also better error handling and documented scripts Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
The controller-manager was gettign OOMkilled with latest changes. Hence bumping up the memory limit Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Consolidate all podvm image related constant in a single place Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This can be used in openshift controller for updating KataConfig CRD Status Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Add status update to KataConfig as well in addition to Kubernetes events Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Modify error strings to not use caps Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Adjust the return values to ensure error is the last return value. Also avoids go-staticcheck warnings Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
getConditionReason and kataOcExists methods are no longer used. However let's keep it for now but ignore it as part of staticcheck warnings Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
getCloudProviderFromInfra getPeerPodsSecret Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
image_request_timeout indicates the image request timeout in the guest needed for the pod. This reduces image pull failures. The param is available from CC-0.8.0 onwards. Fixes: KATA-2771 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Downstream builds can't use binaries. So move the binaries out of the Dockerfile Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This avoids duplication and enables independent dev of both the container images required for building podvm image Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
…rator flow is: credentials-controller creates credentialsRequest for provider upon KataConfig+PeerPods creation -> CCO creates cco-secret in response to provider's credentialsRequests -> credentials-controller triggers by cco-secret creation and translates cco-secrets to peer-pods-secret owned by the cco-secret at deletion of KataConfig: credentials-controller deletes credentialsRequests -> CCO deletes the cco-secret -> GC deletes owned peer-pods-secret Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
go get github.com/openshift/cloud-credential-operator/pkg/apis/cloudcredential/v1@release-4.15 && go mod tidy
Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
This commit introduces the `FeatureGates` struct in the operator's configuration, enabling a flexible and controlled approach to feature rollout. The `FeatureGates` configMap allows for the enabling or disabling of specific features, with a default behaviour based on each feature's maturity level. For each new feature, developers need to modify the "default" struct, just in case users don't have to set their desired behaviour. User's choice will override default values. I'm trying to use a simple approach here where we could change promote/depromote a feature by just changing the comments and the default values. Fixes: #KATA-2677 Signed-off-by: Beraldo Leal <bleal@redhat.com>
Basic instructions on how to use feature gates. Signed-off-by: Beraldo Leal <bleal@redhat.com>
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@bpradipt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
gkurz
added a commit
to gkurz/sandboxed-containers-operator
that referenced
this pull request
Apr 2, 2024
gkurz
added a commit
to gkurz/sandboxed-containers-operator
that referenced
this pull request
Apr 2, 2024
gkurz
added a commit
that referenced
this pull request
Apr 3, 2024
Revert "Merge pull request #385 from openshift/1.6-bump"
gkurz
added a commit
to gkurz/sandboxed-containers-operator
that referenced
this pull request
Apr 8, 2024
gkurz
added a commit
to gkurz/sandboxed-containers-operator
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.