Fix image replacement for builder stage in Installer #6433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stage in the referenced Dockerfiles is `builder`, not `build`.
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
size/L
LorbusChris
commented
Dec 17, 2019
| namespace: ocp | ||
| tag: base | ||
| machine-os-content: | ||
| name: machine-os-content | ||
| namespace: rhcos | ||
| tag: latest | ||
| build_root: | ||
| image_stream_tag: | ||
| cluster: https://api.ci.openshift.org |
There was a problem hiding this comment.
is the cluster ref explicitly needed here?
The stage in the referenced Dockerfiles is `builder`, not `build`.
LorbusChris
force-pushed
the
installer-builder
branch
from
be420bc
to
ec24fc5
Compare
8 tasks
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
No rehearsals were run on this change... https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/6433/pull-ci-openshift-release-master-pj-rehearse/11564#1:build-log.txt%3A73 so hopefully this works. 🤞 |
|
@LorbusChris: Updated the following 16 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The references to the
ocp/builderimage were not replaced, because image replacement in installer is misconfigured:The stage in the referenced Dockerfiles is
builder, notbuild:Here it says input as
build(https://github.com/openshift/release/blob/master/ci-operator/config/openshift/installer/openshift-installer-master.yaml#L17)but in the corresponding Dockerfile it is
AS builder(https://github.com/openshift/installer/blob/master/images/installer/Dockerfile.ci#L4)go vet'ing the flattened vendor dir in Installer with Go Modules. (see e.g.:https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/2745/pull-ci-openshift-installer-master-govet/7136#1:build-log.txt%3A22Also referencing
#6428 (comment)