-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the package name for OSC operator #57546
Conversation
The package name for OSC operator is "sandboxed-containers-operator", as can be seen in the bundle annotation "operators.operatorframework.io.bundle.package.v1". Due to incorrect package name, the installplan never gets created. We could have changed the package name in the OSC code, but then all public documentation will require changes. Consequently making the change to CI yaml is least disruptive Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@gkurz @littlejawa ptal. Hopefully this will fix the e2e |
/pj-rehearse |
@bpradipt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/retest |
/pj-rehearse ack |
@bpradipt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpradipt, snir911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bpradipt: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The package name for OSC operator is "sandboxed-containers-operator", as can be seen in the bundle annotation "operators.operatorframework.io.bundle.package.v1". Due to incorrect package name, the installplan never gets created. We could have changed the package name in the OSC code, but then all public documentation will require changes. Consequently making the change to CI yaml is least disruptive Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
The package name for OSC operator is "sandboxed-containers-operator", as can be seen in the bundle annotation "operators.operatorframework.io.bundle.package.v1".
Due to incorrect package name, the installplan never gets created.
We could have changed the package name in the OSC code, but then all public documentation will require changes. Consequently making the change to CI yaml is least disruptive