Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the package name for OSC operator #57546

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented Oct 7, 2024

The package name for OSC operator is "sandboxed-containers-operator", as can be seen in the bundle annotation "operators.operatorframework.io.bundle.package.v1".

Due to incorrect package name, the installplan never gets created.

We could have changed the package name in the OSC code, but then all public documentation will require changes. Consequently making the change to CI yaml is least disruptive

The package name for OSC operator is "sandboxed-containers-operator",
as can be seen in the bundle annotation "operators.operatorframework.io.bundle.package.v1".

Due to incorrect package name, the installplan never gets created.

We could have changed the package name in the OSC code, but then all public documentation
will require changes. Consequently making the change to CI yaml is least disruptive

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@openshift-ci openshift-ci bot requested review from jensfr and pmores October 7, 2024 17:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bpradipt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-sandboxed-containers-operator-devel-sandboxed-containers-operator-e2e openshift/sandboxed-containers-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bpradipt
Copy link
Contributor Author

bpradipt commented Oct 7, 2024

@gkurz @littlejawa ptal. Hopefully this will fix the e2e

@bpradipt
Copy link
Contributor Author

bpradipt commented Oct 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@bpradipt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bpradipt
Copy link
Contributor Author

bpradipt commented Oct 8, 2024

/retest

@bpradipt
Copy link
Contributor Author

bpradipt commented Oct 8, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@bpradipt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 8, 2024
@littlejawa
Copy link
Contributor

LGTM
Thanks @bpradipt !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, snir911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@bpradipt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 055d712 into openshift:master Oct 8, 2024
14 checks passed
josecastillolema pushed a commit to josecastillolema/release that referenced this pull request Oct 15, 2024
The package name for OSC operator is "sandboxed-containers-operator",
as can be seen in the bundle annotation "operators.operatorframework.io.bundle.package.v1".

Due to incorrect package name, the installplan never gets created.

We could have changed the package name in the OSC code, but then all public documentation
will require changes. Consequently making the change to CI yaml is least disruptive

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants