Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo Promtail changes in 37832 and 37909 #38040

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

jeffdyoung
Copy link
Contributor

@jeffdyoung jeffdyoung commented Apr 4, 2023

Unable to usequay.io/openshift-logging/promtail:v2.7.4 because it isn't build for arm64.
Basically reverting these PRs:
#37832
#37909

@jeffdyoung
Copy link
Contributor Author

/assign @dgoodwin @vrutkovs

@openshift-ci-robot
Copy link
Contributor

@jeffdyoung: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-kube-descheduler-operator-master-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.15-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.14-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.13-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.12-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.11-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.10-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.9-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.8-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.7-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.6-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.5-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.4-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.3-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.2-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.1-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-backube-volsync-main-e2e-openshift-helm backube/volsync presubmit Registry content changed
pull-ci-backube-volsync-main-e2e-openshift backube/volsync presubmit Registry content changed
pull-ci-backube-volsync-main-e2e-openshift-fips backube/volsync presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-main-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.15-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.14-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.13-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.12-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.11-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.10-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-red-hat-storage-odf-multicluster-orchestrator-release-4.9-integration-test red-hat-storage/odf-multicluster-orchestrator presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-master-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.15-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.14-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.13-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.12-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.11-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.10-debug-winc-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-master-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed

A total of 12714 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from dgoodwin and xueqzhan April 4, 2023 12:22
@dgoodwin
Copy link
Contributor

dgoodwin commented Apr 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jeffdyoung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@deepsm007
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@jeffdyoung: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c1a4815 into openshift:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants