Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-35989: coreos-cryptfs: drop growpart call #1536

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[release-4.14] OCPBUGS-35989: coreos-cryptfs: drop growpart call #1536

merged 1 commit into from
Jul 2, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1522

/assign madhu-pillai

@madhu-pillai @jlebon
coreos-cryptfs: drop growpart call
6568be6 
It was weird how we would growpart *on every boot* in the old-style LUKS
code path. In comparison, on new installs nowadays, we only growpart
once on first boot and never again. Since we don't support new installs
that use the old-style LUKS scheme anymore, let's just drop the growpart
call.

This also fixes some issues we've been seeing on s390x systems using
DASD devices where it would make the device temporarily unaccessible
due to sfdisk not understanding DASD partitioning, and some locking that
growpart does that lingers and breaks the following `blockdev` call.

Fixes: https://issues.redhat.com/browse/OCPBUGS-33124

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33124 has been cloned as Jira Issue OCPBUGS-35989. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-35989: coreos-cryptfs: drop growpart call

In response to this:

This is an automated cherry-pick of #1522

/assign madhu-pillai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-33124: coreos-cryptfs: drop growpart call [release-4.14] OCPBUGS-35989: coreos-cryptfs: drop growpart call Jun 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 24, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35989, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-33124 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-33124 to target a version in 4.15.0, 4.15.z, but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1522

/assign madhu-pillai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 24, 2024
@openshift-ci openshift-ci bot requested review from dustymabe and travier June 24, 2024 15:58
jschintag
jschintag approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jschintag jschintag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/jira refresh

/cc @jlebon

@openshift-ci openshift-ci bot requested a review from jlebon June 28, 2024 14:21
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jschintag, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@sdodson
Copy link
Member

sdodson commented Jun 28, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2024
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-35989, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-35988 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-35988 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen June 28, 2024 20:37
@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jun 30, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e93eef9 and 2 for PR HEAD 6568be6 in total

@jschintag
Copy link
Contributor

/retest

@jschintag
Copy link
Contributor

Pipeline failure seems to be caused by mismatching ssl certificates, unrelated to this PR

@sdodson
Copy link
Member

sdodson commented Jul 1, 2024

/retest-required
I believe the certs have been fixed.

@sdodson
Copy link
Member

sdodson commented Jul 1, 2024

/retest-required

@sdodson
Copy link
Member

sdodson commented Jul 2, 2024 

 cluster.go:162: E0701 18:18:50.707020    2123 remote_runtime.go:176] "RunPodSandbox from runtime service failed" err="rpc error: code = Unknown desc = creating pod sandbox with name \"k8s_rhcos-crio-pod-restart-test_redhat.test.crio__0\": initializing source docker://registry.k8s.io/pause:3.9: pinging container registry registry.k8s.io: StatusCode: 403, <!doctype html><meta charset=\"utf-8\"><meta name=vi..."
            cluster.go:162: time="2024-07-01T18:18:50Z" level=fatal msg="run pod sandbox: rpc error: code = Unknown desc = creating pod sandbox with name \"k8s_rhcos-crio-pod-restart-test_redhat.test.crio__0\": initializing source docker://registry.k8s.io/pause:3.9: pinging container registry registry.k8s.io: StatusCode: 403, <!doctype html><meta charset=\"utf-8\"><meta name=vi..."

Image pulls fine from my laptop but that doesn't mean they've not blocked CI infra. But does this test fail elsewhere in other jobs too?

/retest-required

@jschintag
Copy link
Contributor

Image pulls fine from my laptop but that doesn't mean they've not blocked CI infra. But does this test fail elsewhere in other jobs too?

Yes, it fails in the regular CI as well.

@jschintag
Copy link
Contributor

/retest-required

@jschintag
Copy link
Contributor

The only failure in ci/prow/rhcos-92-build-test-qemu is known and unrelated to this PR. Since we want this in the next z-stream release:

/override ci/prow/rhcos-92-build-test-qemu

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

@jschintag: Overrode contexts on behalf of jschintag: ci/prow/rhcos-92-build-test-qemu

In response to this:

The only failure in ci/prow/rhcos-92-build-test-qemu is known and unrelated to this PR. Since we want this in the next z-stream release:

/override ci/prow/rhcos-92-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-92-build-test-qemu 6568be6 link true /test rhcos-92-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8d05da6 into openshift:release-4.14 Jul 2, 2024
5 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35989 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1522

/assign madhu-pillai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschintag jschintag jschintag approved these changes

@dustymabe dustymabe Awaiting requested review from dustymabe

@travier travier Awaiting requested review from travier

@jlebon jlebon Awaiting requested review from jlebon

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@madhu-pillai madhu-pillai

@jschintag jschintag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @sdodson @jschintag @madhu-pillai