make sure [registry]admin covers [registry]edit

[deads2k]

Fixes #9000

@liggitt
[test]

[liggitt]

Add a check to policy_test.go that makes sure all default policy rules set an API group?

[liggitt]

extra test request, LGTM otherwise

[deads2k]

Spoke in person. Will open a separate pull to bring our roles into sync.

[deads2k]

@liggitt Removed the merge tag. I had to add this. Comment is above. its temporary, but significant enough to deserve a second look.

[liggitt]

as long as it's extremely temporary

[liggitt]

test failures:

• integration test router flake: TestRouter integration flake #8502

• authentication/scopedtokens.test/cmd/authentication.sh:30: executing 'oc get projects --token="${listprojecttoken}"' expecting success and text 'cmd-authentication'

  === BEGIN TEST CASE ===
  test/cmd/authentication.sh:30: executing 'oc get projects --token="${listprojecttoken}"' expecting success and text 'cmd-authentication'
  FAILURE after 0.188s: test/cmd/authentication.sh:30: executing 'oc get projects --token="${listprojecttoken}"' expecting success and text 'cmd-authentication': the command returned the wrong error code; the output content test failed
  There was no output from the command.
  Standard error from the command:
  Error from server: scopes [user:list-projects] prevent this action; User "scoped-user" cannot list all projects in the cluster
  === END TEST CASE ===
  

• origin/pkg/authorization/authorizer.TestAPIGroupDeny

  --- FAIL: TestAPIGroupDeny (0.00s)
  panic: api.IsPersonalSubjectAccessReview is not a registered type and cannot be converted into version "unknown/unknown" [recovered]
  panic: api.IsPersonalSubjectAccessReview is not a registered type and cannot be converted into version "unknown/unknown"
  

[openshift-bot]

Evaluated for origin test up to d764705

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4054/)

[deads2k]

[merge]

[deads2k]

conformance problem: https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_conformance/1254/

[deads2k]

conformance wedged again: https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4069/

[deads2k]

and conformance flakes again.

@liggitt I'm not crazy, that test job is green, right?

[deads2k]

this time integration hung: https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4085/

ending with

There was no error output from the command.
Running test/end-to-end/core.sh:176: executing 'oc delete pod cli-with-token-2' expecting success...
SUCCESS after 0.146s: test/end-to-end/core.sh:176: executing 'oc delete pod cli-with-token-2' expecting success
Standard output from the command:
pod "cli-with-token-2" deleted

There was no error output from the command.

[deads2k]

And now a test and problem to look at tomorrow https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4091/

re[merge]

[deads2k]

Yum failures

re[merge]

[openshift-bot]

Evaluated for origin merge up to d764705

[openshift-bot]

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4108/)