Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: e2e: check for deployer SA only when DeploymentConfig is enabled #28939

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund force-pushed the check-for-deployer-only-when-dc-cap-is-enabled branch from 96e349c to dd83cf6 Compare July 18, 2024 12:11
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

/retest

@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@ingvagabund
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 18, 2024
@ingvagabund ingvagabund changed the title e2e: check for deployer SA only when DeploymentConfig is enabled no-jira: e2e: check for deployer SA only when DeploymentConfig is enabled Jul 18, 2024
@openshift-ci-robot
Copy link

@ingvagabund: This pull request explicitly references no jira issue.

In response to this:

Needed for openshift/cluster-version-operator#1066

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fe2c855 and 2 for PR HEAD dd83cf6 in total

@ingvagabund
Copy link
Member Author

/retest-required

1 similar comment
@ingvagabund
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade dd83cf6 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node dd83cf6 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-ipsec-serial dd83cf6 link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: dd83cf6

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (20) are below the historical average (1750): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Medium
[sig-network-edge] Verify DNS availability during and after upgrade success
This test has passed 95.65% of 23 runs on release 4.17 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Low
[sig-architecture] Conformance Tests should have at least two untainted nodes [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
This test has passed 0.00% of 12 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node'] in the last 14 days.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 780ab35 and 1 for PR HEAD dd83cf6 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 3bf7292 into openshift:master Jul 20, 2024
22 of 25 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202407210111.p0.g3bf7292.assembly.stream.el9.
All builds following this will include this PR.

@ingvagabund ingvagabund deleted the check-for-deployer-only-when-dc-cap-is-enabled branch July 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants