-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Skip cert collection tests on hypershift #28937
base: master
Are you sure you want to change the base?
NO-JIRA: Skip cert collection tests on hypershift #28937
Conversation
@vrutkovs: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
test/extended/operators/certs.go
Outdated
@@ -96,6 +96,10 @@ var _ = g.Describe(fmt.Sprintf("[sig-arch][Late][Jira:%q]", "kube-apiserver"), g | |||
if ok, _ := exutil.IsMicroShiftCluster(kubeClient); ok { | |||
g.Skip("microshift does not auto-collect TLS.") | |||
} | |||
configClient := oc.AdminConfigClient() | |||
if ok, _ := exutil.IsHypershift(ctx, configClient); ok { | |||
g.Skip("microshift does not auto-collect TLS.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g.Skip("microshift does not auto-collect TLS.") | |
g.Skip("hypershift does not auto-collect TLS.") |
Hypershift has a different cert structure and tests may flake so skip cert collection for now
f692db3
to
6d7218a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl, vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hypershift has a different cert structure and tests may flake so skip cert collection for now