-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] OCPBUGS-36264: add Proxy config #28912
[release-4.15] OCPBUGS-36264: add Proxy config #28912
Conversation
@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label qe-approved |
@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-gcp-ovn |
d08c49d
to
e031364
Compare
/retest |
1 similar comment
/retest |
@frobware Could you help review this PR? Thanks |
@LiangquanLi930: This pull request references Jira Issue OCPBUGS-36264, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.14 |
@LiangquanLi930: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
test/extended/router/http2.go
Outdated
Timeout: timeout, | ||
Transport: &http.Transport{ | ||
TLSClientConfig: &tlsConfig, | ||
Proxy: http.ProxyFromEnvironment, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This transport is overridden if useHTTP2Transport
is true, so it seems like the test will still fail for the useHTTP2Transport: true
test cases if using a proxy is required.
Would it make sense to backport #28540 too? This is the crucial change from #28540 to avoid overriding the transport that has the proxy configuration:
if useHTTP2Transport {
- c.Transport = &http2.Transport{
- TLSClientConfig: &tlsConfig,
- }
+ // Explicitly allow HTTP/2.
+ http2.ConfigureTransport(transport)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Miciah are you available to review this? I thought we might have to expedite a change to the OWNERS file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a best effort. However, updating OWNERS
shouldn't be blocking anyone from reviewing PRs; if someone else from the team has capacity to review, then that person can add an /lgtm
and then ping me, Miheer, or knobunc to add a rubber-stamp /lgtm
.
e031364
to
eff277f
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, knobunc, LiangquanLi930 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-metal-ipi-ovn-ipv6 |
Let's see if the bug found and fixed by @LiangquanLi930 is ready yet. |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test e2e-metal-ipi-ovn-ipv6 |
3 similar comments
/test e2e-metal-ipi-ovn-ipv6 |
/test e2e-metal-ipi-ovn-ipv6 |
/test e2e-metal-ipi-ovn-ipv6 |
@LiangquanLi930: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Based on the log from this link, the cluster consistently fails to install, so I think we can ignore it. |
Based on past jobs, the job at https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-origin-release-4.15-e2e-metal-ipi-ovn-ipv6 will fail permanently, not just the current job. |
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
@Miciah: Miciah unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Got it, thanks @LiangquanLi930 |
229db64
into
openshift:release-4.15
@LiangquanLi930: Jira Issue OCPBUGS-36264: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36264 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@LiangquanLi930: new pull request created: #28998 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Fix included in accepted release 4.15.0-0.nightly-2024-08-12-233649 |
manual cherry-pick #28880