Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-4850: Add Kuryr exception to "pods should successfully create sandboxes" test #27435

Merged
merged 1 commit into from
Nov 22, 2022
Merged

OCPBUGS-4850: Add Kuryr exception to "pods should successfully create sandboxes" test #27435

merged 1 commit into from
Nov 22, 2022

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Sep 22, 2022

Kuryr can take long to create Pods as it needs to create ports for these pods in Neutron. If a pod gets deleted while this is being processed, a warning Event will be generated. This causes the [sig-network] pods should successfully create sandboxes by adding pod to network to fail.

This commit adds this case as a flake.

@dulek
Add Kuryr exception to "pods should successfully create sandboxes" test
374c497 
Kuryr can take long to create Pods as it needs to create ports for these
pods in Neutron. If a pod gets deleted while this is being processed, a
warning Event will be generated. This causes the `[sig-network] pods
should successfully create sandboxes by adding pod to network` to fail.

This commit adds this case as a flake.
@dulek
Copy link
Contributor Author

dulek commented Sep 22, 2022

See [1] for an example failure.

[1] https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kuryr-kubernetes/691/pull-ci-openshift-kuryr-kubernetes-master-e2e-openstack-kuryr/1572902208108761088

@dulek
Copy link
Contributor Author

dulek commented Sep 22, 2022

/test e2e-openstack-kuryr

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@dulek: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upgrade
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking
  • /test images
  • /test lint
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-proxy
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test e2e-openstack-kuryr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bparees and spadgett September 22, 2022 15:33
@MaysaMacedo
Copy link
Contributor

/retest
/lgtm
It would be nice to test it somehow

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@MaysaMacedo
Copy link
Contributor

Proposal do add an optional Kuryr job openshift/release#32762

@dulek dulek mentioned this pull request Oct 6, 2022
Merged
@dulek
Copy link
Contributor Author

dulek commented Oct 6, 2022

/test e2e-openstack-kuryr

@dulek
Copy link
Contributor Author

dulek commented Oct 6, 2022

/retest-required

@dulek
Copy link
Contributor Author

dulek commented Oct 10, 2022

Test seems to be passing as a flake, which is what we wanted. I'm not rechecking, a different problem appeared, but this PR seems to fix the problem it intended to.

@dulek
Copy link
Contributor Author

dulek commented Oct 10, 2022

/assign @spadgett

Please take a look, this unblocks e2e-openstack-kuryr CIs.

@MaysaMacedo
Copy link
Contributor

The new issue in the Kuryr CI might be related to https://issues.redhat.com/browse/OCPBUGS-2061, which is not an issue with Kuryr itself

@dulek
Copy link
Contributor Author

dulek commented Oct 12, 2022

/test e2e-openstack-kuryr

Just out of curiosity if the problem Maysa mentioned above is fixed.

@dulek
Copy link
Contributor Author

dulek commented Oct 24, 2022

@bparees, @spadgett, could you take a look here? It's to unblock a CI that's failing quite a lot on 4.12.

@MaysaMacedo
Copy link
Contributor

/retest

@bparees
Copy link
Contributor

bparees commented Oct 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@dulek
Copy link
Contributor Author

dulek commented Oct 24, 2022

/retest-required

1 similar comment
@dulek
Copy link
Contributor Author

dulek commented Oct 25, 2022

/retest-required

@dulek
Copy link
Contributor Author

dulek commented Oct 25, 2022

/retest-required

Weirdly it does seem to fail on a similar set of tests. Yet I strongly doubt this patch can affect it in a negative way.

@dulek
Copy link
Contributor Author

dulek commented Oct 26, 2022

/retest-required

2 similar comments
@dulek
Copy link
Contributor Author

dulek commented Nov 2, 2022

/retest-required

@MaysaMacedo
Copy link
Contributor

/retest-required

@MaysaMacedo
Copy link
Contributor

/test e2e-gcp-ovn-image-ecosystem

@MaysaMacedo
Copy link
Contributor

/test e2e-gcp-ovn-image-ecosystem

2 similar comments
@MaysaMacedo
Copy link
Contributor

/test e2e-gcp-ovn-image-ecosystem

@MaysaMacedo
Copy link
Contributor

/test e2e-gcp-ovn-image-ecosystem

@MaysaMacedo
Copy link
Contributor

/retest

This was referenced Nov 14, 2022
Merged
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 640432d and 2 for PR HEAD 374c497 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022 •
edited
Loading

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 374c497 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn 374c497 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 374c497 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 374c497 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fd8e83c and 1 for PR HEAD 374c497 in total

@openshift-merge-robot openshift-merge-robot merged commit 0b36a06 into openshift:master Nov 22, 2022
@MaysaMacedo
Copy link
Contributor

/cherry-pick release-4.12

@MaysaMacedo
Copy link
Contributor

/retitle OCPBUGS-4850: Add Kuryr exception to "pods should successfully create sandboxes" test

@openshift-ci openshift-ci bot changed the title Add Kuryr exception to "pods should successfully create sandboxes" test OCPBUGS-4850: Add Kuryr exception to "pods should successfully create sandboxes" test Dec 14, 2022
@openshift-ci-robot
Copy link

@dulek: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4850 has been moved to the MODIFIED state.

In response to this:

Kuryr can take long to create Pods as it needs to create ports for these pods in Neutron. If a pod gets deleted while this is being processed, a warning Event will be generated. This causes the [sig-network] pods should successfully create sandboxes by adding pod to network to fail.

This commit adds this case as a flake.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 14, 2022
Merged
@openshift-cherrypick-robot
Copy link

@MaysaMacedo: new pull request created: #27611

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@spadgett spadgett

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dulek @MaysaMacedo @bparees @openshift-ci-robot @openshift-cherrypick-robot @spadgett @openshift-merge-robot