Bug 1986003: Switch kubeconfig retries to use backoff #26407
Conversation
This logic will retry the kubeconfig check after 2, 10 and finally after 50s.
|
@soltysh: This pull request references Bugzilla bug 1986003, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
@soltysh: This pull request references Bugzilla bug 1986003, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
... and detecting the pods is running and ready before doing the check? |
|
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-ovn-ipv6/1428006633924988928 failed the local kubeconfig test today, which was after #26377 merged -- should this PR fix those? |
|
/retest-required |
| matched, _ := regexp.MatchString("The connection to the server .+ was refused - did you specify the right host or port", out) | ||
| return !matched, err | ||
| if err != nil { | ||
| return fmt.Errorf(out) |
There was a problem hiding this comment.
is The connection to the server .+ was refused - did you specify the right host or port reported in out?
There was a problem hiding this comment.
Yeah, I had to switch from using err to out due to how wait.Retry uses 2 separate functions for action and decision about retry.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-agnostic-cmd |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd, ci/prow/e2e-aws-single-node In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp-upgrade |
|
@soltysh: Bugzilla bug 1986003 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a followup to #26377 but I'm switching this time to use backoff, so it'll retry more but it'll do that after 2, 10 and 50 seconds.
In https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26401/pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6/1427903228267204608 I've noticed we did retry, but every 2s which was too fast 😞
/assign @aojea