Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1898118: Logging more during ephemeral registry deployment #25690

Merged
merged 3 commits into from
Nov 21, 2020
Merged

Bug 1898118: Logging more during ephemeral registry deployment #25690

merged 3 commits into from
Nov 21, 2020

Conversation

ricardomaraschini
Copy link
Contributor

This patch increases the number of logged information during the
following tests:

ImageStream API TestImportRepositoryFromBlockedRegistry
ImageStream API TestImportImageFromBlockedRegistry
ImageStream API TestImportImageFromInsecureRegistry
ImageStream API TestImportRepositoryFromInsecureRegistry

Tests now log the deployment status. Time between polls was also
increased, no need to rush when checking for the deployment status.

Timeout for endpoints to become available were also increased, from one
to five minutes, logging was also increased during endpoints check.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Nov 16, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1898118, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

WIP - Bug 1898118: Logging more during ephemeral registry deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 16, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@ricardomaraschini
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 16, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1898118, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini
Logging more during ephemeral registry deployment
c6b1737 
This patch increases the number of logged information during the
following tests:

ImageStream API TestImportRepositoryFromBlockedRegistry
ImageStream API TestImportImageFromBlockedRegistry
ImageStream API TestImportImageFromInsecureRegistry
ImageStream API TestImportRepositoryFromInsecureRegistry

Tests now log the deployment status. Time between polls was also
increased, no need to rush when checking for the deployment status.

Timeout for endpoints to become available were also increased, from one
to five minutes, logging was also increased during endpoints check.
@ricardomaraschini ricardomaraschini changed the title WIP - Bug 1898118: Logging more during ephemeral registry deployment Bug 1898118: Logging more during ephemeral registry deployment Nov 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2020
@ricardomaraschini
Copy link
Contributor Author

/assign @dmage

@dmage
Copy link
Contributor

dmage commented Nov 18, 2020

/lgtm

@dmage
Copy link
Contributor

dmage commented Nov 18, 2020

/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 18, 2020
@ricardomaraschini
Using test namespace to deploy ephemeral registry
f1cd750 
Instead of creating a new project to deploy the registry this patch
makes us to use the namespace created by the test framework. This patch
also includes a complete dump of all objects in the namespace if the
registry deployment fails.
dmage
dmage reviewed Nov 18, 2020
View reviewed changes
test/extended/images/imagestreamimport.go Outdated
}); err != nil {
return err
e2e.DumpAllNamespaceInfo(oc.AdminKubeClient(), oc.Namespace())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to call this function for oc.Namespace(). This repository uses Ginkgo that makes tests more declarative. The namespace is created in BeforeEach and is deleted in AfterEach, all necessary debug information for the namespace is generated by AfterEach. I guess these tests also should use BeforeEach and AfterEach and shouldn't use g.GinkgoTInterface and the latter is a helper for legacy code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@ricardomaraschini
Copy link
Contributor Author

/retest

@dmage
Copy link
Contributor

dmage commented Nov 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Contributor

dmage commented Nov 20, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a0f112f into openshift:master Nov 21, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: All pull requests linked via external trackers have merged:

Bugzilla bug 1898118 has been moved to the MODIFIED state.

In response to this:

Bug 1898118: Logging more during ephemeral registry deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage dmage left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ricardomaraschini @openshift-ci-robot @dmage @openshift-bot @openshift-merge-robot