Add bootstrap kube:admin OAuth user #21580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
woot! |
Signed-off-by: Monis Khan <mkhan@redhat.com>
enj
force-pushed
the
enj/f/bootstrap_oauth_user
branch
from
7c1b483
to
4f9b5c7
Compare
|
/retest |
|
I mostly follow this. Can you add an e2e in a follow up that verifies this flow works on a cluster if no idp is configured (create the secret, verify you get an oauth token, and the token works), or skips if no idp is configured? |
|
/lgtm We can iterate more before beta if we have gaps |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Monis Khan mkhan@redhat.com
@openshift/sig-auth @smarterclayton @derekwaynecarr