An image represents a manifest (and is a blob) and also references a config #20458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config Our external API and internal structure is wrong. All images are manifests, and all manifests are blobs. In addition, a v2 schema 2 manifest references a blob that is a "config", not a "manifest". Corrected the internal code so that the image/manifest digest now shows up in blobs, renamed the internal field "config", and set the correct mime types and fixed tests.
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
|
Second API change is in openshift/api#79 |
|
how did this pass tests w/o either the internal or external api changes? |
|
I didn’t change the api in this. This corrects the issue. The api is just cosmetic and can be done second |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our external API and internal structure is wrong. All images are manifests, and all manifests are blobs.
In addition, a v2 schema 2 manifest references a blob that is a "config", not a "manifest".
Corrected the internal code so that the image/manifest digest now shows up in blobs, renamed the internal
field "config", and set the correct mime types and fixed tests.
Replaces openshift/image-registry#115