Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tls update from purview of routes/custom-host #18195

Closed
wants to merge 1 commit into from
Closed

remove tls update from purview of routes/custom-host #18195

wants to merge 1 commit into from

Conversation

rajatchopra
Copy link
Contributor

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1524707

This is an alternate to issue #18177

ps - the unit tests need to be updated still, so hold off on any merge
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajatchopra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2018
@rajatchopra rajatchopra mentioned this pull request Jan 19, 2018
Closed
enj
enj reviewed Jan 19, 2018
View reviewed changes
pkg/route/registry/route/strategy.go Outdated
@@ -214,6 +214,26 @@ func (s routeStrategy) validateHostUpdate(ctx apirequest.Context, route, older *
if hostChanged {
return kvalidation.ValidateImmutableField(route.Spec.Host, older.Spec.Host, field.NewPath("spec", "host"))
}
}
tlsRes, err := s.sarClient.Create(
authorizationutil.AddUserToSAR(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RBAC would not let you invoke an update to a route if you did not already have this permission. So this SAR does not make sense since it would always return true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@openshift-ci-robot
Copy link

@rajatchopra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit 7de97e7 link /test unit
ci/openshift-jenkins/extended_conformance_install 7de97e7 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett mentioned this pull request Jan 22, 2018
Closed
@spadgett
Copy link
Member

@rajatchopra Please tag the UI team on PRs that might affect the web console route editor.

@jwforres cc

@smarterclayton
Copy link
Contributor

/hold

I added a comment to the bug, but this was an intentional change. Let's close out the discussion there first.

@enj enj mentioned this pull request Jan 25, 2018
Closed
@enj
Copy link
Contributor

enj commented Jan 26, 2018

Superseded by #18177

@enj enj closed this Jan 26, 2018
@rajatchopra rajatchopra deleted the tls_admit branch March 6, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj left review comments

@pecameron pecameron Awaiting requested review from pecameron

@pravisankar pravisankar Awaiting requested review from pravisankar

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajatchopra @openshift-ci-robot @spadgett @smarterclayton @enj