-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oc run help #14769
Update oc run help #14769
Conversation
pkg/cmd/cli/cmd/wrappers.go
Outdated
%[1]s run nginx --image=nginx --command -- <cmd> <arg1> ... <argN> | ||
|
||
# Start the perl container to compute π to 2000 places and print it out. | ||
%[1]s run pi --image=perl --restart=OnFailure -- perl -Mbignum=bpi -wle 'print bpi(2000)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a job for a job :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a job, but I'll update the description.
@soltysh while you are here, i always missed the example of using deployment generator over the deployment config (we override upstream), would be nice to have that here as well? |
I've also added a section about generators to our docs: openshift/openshift-docs#4612 |
[test] |
Evaluated for origin test up to 0787e5b |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2423/) (Base Commit: e50d999) (PR Branch Commit: 0787e5b) |
@mfojtik makes sense, although I don't want to make that help too lengthy (it's already is quite packed). That's why I've updated the docs with list of supported generators. |
LGTM |
[merge][severity:blocker] |
Flake #12487 |
Flake #11452 |
Evaluated for origin merge up to 0787e5b |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1083/) (Base Commit: 47808f7) (PR Branch Commit: 0787e5b) (Extended Tests: blocker) (Image: devenv-rhel7_6392) |
@openshift/cli-review ptal, this is a minor thing, but worth having I've been wanted to have that one in for a long, already.