Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oc run help #14769

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Update oc run help #14769

merged 1 commit into from
Jun 22, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 20, 2017

@openshift/cli-review ptal, this is a minor thing, but worth having I've been wanted to have that one in for a long, already.

%[1]s run nginx --image=nginx --command -- <cmd> <arg1> ... <argN>

# Start the perl container to compute π to 2000 places and print it out.
%[1]s run pi --image=perl --restart=OnFailure -- perl -Mbignum=bpi -wle 'print bpi(2000)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a job for a job :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a job, but I'll update the description.

@mfojtik
Copy link
Contributor

mfojtik commented Jun 20, 2017

@soltysh while you are here, i always missed the example of using deployment generator over the deployment config (we override upstream), would be nice to have that here as well?

@soltysh
Copy link
Contributor Author

soltysh commented Jun 20, 2017

I've also added a section about generators to our docs: openshift/openshift-docs#4612

@mfojtik
Copy link
Contributor

mfojtik commented Jun 20, 2017

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0787e5b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2423/) (Base Commit: e50d999) (PR Branch Commit: 0787e5b)

@soltysh
Copy link
Contributor Author

soltysh commented Jun 20, 2017

@mfojtik makes sense, although I don't want to make that help too lengthy (it's already is quite packed). That's why I've updated the docs with list of supported generators.

@juanvallejo
Copy link
Contributor

LGTM

@mfojtik
Copy link
Contributor

mfojtik commented Jun 21, 2017

[merge][severity:blocker]

@soltysh
Copy link
Contributor Author

soltysh commented Jun 21, 2017

Flake #12487
[merge][severity:blocker]

@soltysh
Copy link
Contributor Author

soltysh commented Jun 22, 2017

Flake #11452
[merge][severity:blocker]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0787e5b

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 22, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1083/) (Base Commit: 47808f7) (PR Branch Commit: 0787e5b) (Extended Tests: blocker) (Image: devenv-rhel7_6392)

@openshift-bot openshift-bot merged commit e6c7c92 into openshift:master Jun 22, 2017
@soltysh soltysh deleted the update_run_help branch June 22, 2017 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants