UPSTREAM: 46771 Allow pv-binder-controller to List Nodes/Zones Available in the Cluster #14415
Conversation
|
LGTM @childsb can you merge? |
|
[test] |
pospispa
force-pushed
the
bugzilla1457092-Dynamic-provisioning-failed-when-zone-is-not-specified-in-the-StorageClass-incorrect-scc-permissions-for-pv-controller
branch
2 times, most recently
from
208e80c to
b885ed7
Compare
|
[merge][severity:blocker] |
|
flake #8502 |
|
[merge][severity:blocker] |
|
you can do it rosie |
|
flake #13271 |
|
flake #14460 |
|
@liggitt @childsb created corresponding upstream PR: kubernetes/kubernetes#46870 |
|
sorry I was unclear... there was already an upstream PR for this issue. in the future, if you need to make permission changes for upstream controllers, be sure to open corresponding PRs upstream. thanks. |
|
@liggitt whats the existing PR? |
|
The existing PR is kubernetes/kubernetes#46771 |
…able in the Cluster Backport of K8s PR #46771. Cinder provisioner chooses a zone from the list of zones available in the cluster in case no zone is specified in the corresponding Storage Class. However, currently the provisioner (pv-binder-controller) does not have right to get the list of nodes/zones available in the cluster. That's why the pv-binder-controller is being given permission to list and watch nodes in the cluster.
pospispa
force-pushed
the
bugzilla1457092-Dynamic-provisioning-failed-when-zone-is-not-specified-in-the-StorageClass-incorrect-scc-permissions-for-pv-controller
branch
from
b885ed7 to
54b994c
Compare
|
Evaluated for origin test up to 54b994c |
|
Per pospispa - Code is slightly different structure in openshift for same function. |
|
[merge][severity:blocker] |
|
Evaluated for origin merge up to 54b994c |
childsb
changed the title
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1914/) (Base Commit: 5f2f3f4) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/888/) (Base Commit: 663ad03) (Extended Tests: blocker) (Image: devenv-rhel7_6296) |
Cinder, AWS and GCE provisioners choose a zone from the list of zones available in the cluster in case no zone is specified in the corresponding Storage Class. However, currently the provisioner (pv-binder-controller) do not have right to get the list of nodes/zones available in the cluster.
That's why the pv-binder-controller is being given permission to list and watch nodes in the cluster.
IMPORTANT: this PR was NOT tested.
This PR should resolves this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457092
This PR does not require any documentation changes.
@rootfs PTAL