Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing quickstart credentials to secrets #12055

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Changing quickstart credentials to secrets #12055

merged 1 commit into from
Dec 2, 2016

Conversation

jupierce
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1233513

@bparees Should this go beyond quickstarts? Jenkins templates? All examples?

@bparees
Copy link
Contributor

bparees commented Nov 29, 2016

@bparees Should this go beyond quickstarts? Jenkins templates? All examples?

quickstarts, db-templates, and jenkins should probably all be done. Actually jenkins shouldn't have any passwords in it anymore.

@bparees
Copy link
Contributor

bparees commented Nov 29, 2016

@jupierce the quickstarts directory is updated via script, you need to update the files in their original repos and then run the hack/update-external-examples.sh script. (see the readme in the quickstarts directory, though it should be fixed to say "do not modify/add files to this directory" instead of just "Do not add files to this directory")

@bparees
Copy link
Contributor

bparees commented Nov 29, 2016

@jwforres fyi

@jupierce
Copy link
Contributor Author

@jupierce
Copy link
Contributor Author

Quickstarts have now been synched with hack script.

@bparees
Copy link
Contributor

bparees commented Nov 30, 2016

lgtm, will wait on extended tests to finish.

@bparees bparees self-assigned this Nov 30, 2016
@bparees
Copy link
Contributor

bparees commented Nov 30, 2016

@jupierce the mongo petset replication failure is a new one.

@jupierce
Copy link
Contributor Author

@bparees I've been looking at it, but that test doesn't even use the modified templates. It uses: https://raw.githubusercontent.com/sclorg/mongodb-container/master/examples/petset/mongodb-petset-persistent.yaml

As best I can tell, the cause is:

Nov 30 13:08:54.128: INFO: At 2016-11-30 13:06:54 -0500 EST - event for mongodb-replicaset-0: {default-scheduler } FailedScheduling: SchedulerPredicates failed due to PersistentVolumeClaim is not bound: "mongo-data-mongodb-replicaset-0", which is unexpected.

@bparees
Copy link
Contributor

bparees commented Nov 30, 2016

@jupierce hm. may well be a flake i suppose.

@jupierce
Copy link
Contributor Author

[testextended][extended:core(image_ecosystem)]

@bparees
Copy link
Contributor

bparees commented Dec 1, 2016

back to the known failure. merging w/ your additional petset debug changes.
[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@bparees
Copy link
Contributor

bparees commented Dec 1, 2016

flake #11887
[merge]

@jupierce
Copy link
Contributor Author

jupierce commented Dec 1, 2016

Incorporating changes for #12075

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to 0d886ad

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0d886ad

@bparees
Copy link
Contributor

bparees commented Dec 1, 2016

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11874/) (Base Commit: a38151f)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/856/) (Base Commit: a38151f) (Extended Tests: core(image_ecosystem))

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0d886ad

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11916/) (Base Commit: 82b0df4) (Image: devenv-rhel7_5463)

@openshift-bot openshift-bot merged commit 7b90443 into openshift:master Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants