-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing quickstart credentials to secrets #12055
Changing quickstart credentials to secrets #12055
Conversation
quickstarts, db-templates, and jenkins should probably all be done. Actually jenkins shouldn't have any passwords in it anymore. |
@jupierce the quickstarts directory is updated via script, you need to update the files in their original repos and then run the hack/update-external-examples.sh script. (see the readme in the quickstarts directory, though it should be fixed to say "do not modify/add files to this directory" instead of just "Do not add files to this directory") |
@jwforres fyi |
Quickstarts have now been synched with hack script. |
lgtm, will wait on extended tests to finish. |
@jupierce the mongo petset replication failure is a new one. |
@bparees I've been looking at it, but that test doesn't even use the modified templates. It uses: https://raw.githubusercontent.com/sclorg/mongodb-container/master/examples/petset/mongodb-petset-persistent.yaml As best I can tell, the cause is:
|
@jupierce hm. may well be a flake i suppose. |
[testextended][extended:core(image_ecosystem)] |
back to the known failure. merging w/ your additional petset debug changes. |
[Test]ing while waiting on the merge queue |
flake #11887 |
Incorporating changes for #12075 |
Evaluated for origin testextended up to 0d886ad |
Evaluated for origin test up to 0d886ad |
[merge] |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11874/) (Base Commit: a38151f) |
continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/856/) (Base Commit: a38151f) (Extended Tests: core(image_ecosystem)) |
Evaluated for origin merge up to 0d886ad |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11916/) (Base Commit: 82b0df4) (Image: devenv-rhel7_5463) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1233513
@bparees Should this go beyond quickstarts? Jenkins templates? All examples?