Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: cleanup dc controller #11426

Merged
merged 1 commit into from
Oct 25, 2016
Merged

deploy: cleanup dc controller #11426

merged 1 commit into from
Oct 25, 2016

Conversation

0xmichalis
Copy link
Contributor

Since upstream are going to support up to two old releases, there is no
reason for us to continue supporting pre 1.1 clients. This commit makes
the deployment config controller a maintainable piece of code again after
a long time:)

@mfojtik @smarterclayton

@0xmichalis
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor

Add a release note and @brenton that 3.1 -> 3.4 upgrade will not be allowed
directly.

On Oct 18, 2016, at 5:58 PM, Michail Kargakis notifications@github.com
wrote:

[test]


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11426 (comment),
or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABG_p3RXk5CQ2Zdb0x4VrYX-uRtgAXdRks5q1UEggaJpZM4KaVn1
.

@brenton
Copy link
Contributor

brenton commented Oct 19, 2016

@smarterclayton, The upgrade playbooks today require that customers upgrade sequentially without skipping any steps.

@0xmichalis
Copy link
Contributor Author

Release note added: openshift/openshift-docs#2933 (comment)

@0xmichalis
Copy link
Contributor Author

#11240 [test]

Since upstream are going to support up to two old releases, there is no
reason for us to continue supporting pre 1.1 clients. This commit makes
the deployment config controller a maintainable piece of code again after
a long time:)
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 066150d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10448/) (Base Commit: 2016d68)

@mfojtik
Copy link
Contributor

mfojtik commented Oct 25, 2016

LGTM

@0xmichalis
Copy link
Contributor Author

[merge]

@mfojtik
Copy link
Contributor

mfojtik commented Oct 25, 2016

approved for 3.4

[merge]

@mfojtik mfojtik added this to the 1.4.0 milestone Oct 25, 2016
@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 066150d

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 25, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10448/) (Base Commit: 50efe7d) (Image: devenv-rhel7_5239)

@openshift-bot openshift-bot merged commit ca1c204 into openshift:master Oct 25, 2016
@0xmichalis 0xmichalis deleted the cleanup-dc-controller branch October 25, 2016 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants