Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 34028: Add --dry-run option to oc create sub-commands #11238

Merged
merged 5 commits into from
Oct 19, 2016
Merged

UPSTREAM: 34028: Add --dry-run option to oc create sub-commands #11238

merged 5 commits into from
Oct 19, 2016

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Oct 5, 2016 •
edited
Loading

UPSTREAM: kubernetes/kubernetes#34028

Fixes #10426

List of commands to address:

  • oc create [-f ...]
  • oc create clusterresourcequota
  • oc create deploymentconfig
  • oc create identity
  • oc create imagestream
  • oc create policybinding
  • oc create route
  • oc create user
  • oc create useridentitymapping

cc @openshift/cli-review @smarterclayton

This was referenced Oct 6, 2016
Merged
Closed
@juanvallejo juanvallejo changed the title [WIP] Add --dry-run option to oc create sub-commands Add --dry-run option to oc create sub-commands Oct 11, 2016
@juanvallejo
Copy link
Contributor Author

@openshift/cli-review PTAL

@juanvallejo juanvallejo changed the title Add --dry-run option to oc create sub-commands UPSTREAM: 34028: Add --dry-run option to oc create sub-commands Oct 11, 2016
@fabianofranz
Copy link
Member

Once kubernetes/kubernetes#34502 and #10993 merges, we could add a verify-cli-conventions.sh check to make sure every command under create has a --dry-run flag.

@fabianofranz
Copy link
Member

Overall LGTM, let's see how upstream goes.

@juanvallejo
Copy link
Contributor Author

@fabianofranz Sounds good, thanks for taking a look! I've added the oc create -f ... command as well to the list, per this suggestion upstream.

@juanvallejo juanvallejo force-pushed the jvallejo/add-dry-run-option-oc-create branch from 09a947f to f8e27a0 Compare October 11, 2016 19:18
@juanvallejo juanvallejo force-pushed the jvallejo/add-dry-run-option-oc-create branch from f8e27a0 to 2369eab Compare October 17, 2016 14:19
@juanvallejo
Copy link
Contributor Author

@fabianofranz Upstream merged! kubernetes/kubernetes#34028
@soltysh Added the dry-run option to kubectl apply to this PR as well if that is okay with you: d9d259b

@fabianofranz
Copy link
Member

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 17, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10120/) (Image: devenv-rhel7_5206)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 18d604e

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 18d604e

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10120/) (Base Commit: 92a71d4)

@openshift-bot openshift-bot merged commit a49b2bc into openshift:master Oct 19, 2016
@juanvallejo juanvallejo deleted the jvallejo/add-dry-run-option-oc-create branch October 19, 2016 18:05
@smarterclayton
Copy link
Contributor

oc create route edge --dry-run -o yaml doesn't seem to work

@juanvallejo
Copy link
Contributor Author

@smarterclayton thanks, will address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanvallejo @fabianofranz @openshift-bot @smarterclayton