unable to determine resource for scale target reference

[mfojtik]

In ca-central-1 I can see a lot of errors in controller manager like this:

1 horizontal.go:189] unable to determine resource for scale target reference: no matches for kind "DeploymentConfig" in group "extensions"
1 horizontal.go:189] unable to determine resource for scale target reference: no matches for kind "ReplicationController" in group "apps"

We do carry a patch here I believe: https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/controller/podautoscaler/horizontal.go#L402

We have this so we can handle OpenShift oapi DeploymentConfig, what is not clear to me is why the passed GroupKind is "extensions.DeploymentConfig" (?) and also why we see "apps.ReplicationController" (RC is part of core).

We are getting the GV from here: https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/controller/podautoscaler/horizontal.go#L388 (do we have some HPA created with wrong APIVersion?)

/cc @DirectXMan12
/cc @deads2k
/cc @liggitt

[mfojtik]

OK, I checked and we indeed have some HPA with wrong scaleTargetRef:

...
spec:
  maxReplicas: 10
  minReplicas: 1
  scaleTargetRef:
    apiVersion: apps/v1beta1
    kind: ReplicationController

@DirectXMan12 shouldn't we validate this when the HPA is created and refuse to create HPA that points to an non-existing resource? (well that resource might start to exists later...)...

[liggitt]

see #18517 (comment) which was supposed to migrate these references

[DirectXMan12]

I know about extensions.DC (the webconsole was doing interesting stuff), but I've never seen apps.RC, and I don't think we handle that, because it was not a known case (webconsole creates everything as extensions.XYZ, so all of those should be handled).

[DirectXMan12]

Any idea what created apps.RC? Could just be a user error.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.