Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable idler #15101

Closed
deads2k opened this issue Jul 7, 2017 · 3 comments
Closed

Re-enable idler #15101

deads2k opened this issue Jul 7, 2017 · 3 comments
Assignees
Milestone

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 7, 2017

#15100 is failing on idler compilation problems. I made some changes in separate: DANW: endpointsconfighandler changes which may or may not have helped, so feel free to revert those.

This is blocking progress on the rebase since we cannot complete a compile and get a master without having this work.

# github.com/openshift/origin/pkg/proxy/hybrid
pkg/proxy/hybrid/proxy.go:97: not enough arguments in call to p.unidlingProxy.OnServiceUpdate
	have ([]*"github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/api".Service)
	want (*"github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/api".Service, *"github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/api".Service)
# github.com/openshift/origin/pkg/proxy/unidler
pkg/proxy/unidler/unidlersocket.go:265: svcInfo.ServiceRef undefined (type *userspace.ServiceInfo has no field or method ServiceRef)
pkg/proxy/unidler/unidlersocket.go:345: svcInfo.ServiceRef undefined (type *userspace.ServiceInfo has no field or method ServiceRef)
@deads2k deads2k added this to the 3.7.0 milestone Jul 7, 2017
@deads2k deads2k mentioned this issue Jul 7, 2017
9 tasks
@danwinship
Copy link
Contributor

from #15100:

It looks like the upstream types were renamed to EndpointsHandler and ServiceHandler. This is going to need a bunch of work though because the interfaces have grown and HybridProxier needs to implement the new functions.

@pweil- pweil- added component/kubernetes kind/bug Categorizes issue or PR as related to a bug. labels Jul 10, 2017
@DirectXMan12
Copy link
Contributor

@deads2k I'll try to get you a PR to fix this as soon as possible (hopefully Monday or Tuesday). I'm fine with merging the rebase with a disabled unidler, though, if that makes your life easier.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 18, 2017

The rebase branch is reviewed and green. You can build a new pull using it as the base, but I think that pull is done. See the #15234 for base.

@deads2k deads2k mentioned this issue Jul 18, 2017
56 tasks
@deads2k deads2k changed the title unidler fails to compile on kube 1.7 Re-enable idler Jul 18, 2017
openshift-merge-robot added a commit that referenced this issue Aug 25, 2017
Automatic merge from submit-queue (batch tested with PRs 15881, 15905, 15383, 15938)

Restore Unidler

Fixes #15101

The unidler was broken by changes to the structure of the proxies upstream.
This PR refactors the hybrid proxier to follow the event-driven model used by the
upstream proxies, and works around the lack of the ObjectReference in ServiceInfo
(we fake a lightweight ObjectReference using service name and namespace, which is
just enough for the unidler controller).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants