[4.15] Bug OCPBUGS-32351 - backporting service-step fixes #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serious issues:
- Nothing powers on nodes after servicing, so they end up active and
powered off in the end.
- Restoring power state was done three times.
Minor issues:
- Function _tear_down_node_servicing is called twice causing a traceback.
- Furthermore, process_event('done') is also called in another place
in deploy utils.
- Make sure nodes are never considered for fast-track when servicing, it
prevents clean-up of virtual media devices.
Change-Id: I92fd7a0009a816e93e316e4674c7509b61a474d4
Currently, service steps do not work with virtual media deployments because states.SERVICING and states.SERVICEWAIT are missing from the whitelist of valid provision_states. This change resolves this issue. Change-Id: I5e3ec08d128b35385f2d90c9c852140b757b8dbf
Currently, service steps may fail to start in scenarios dependent on IPA fasttrack. This change attempts to resolve this by incorporating servicing states in the fast track allowed states whitelist while also making _FASTTRACK_HEARTBEAT_ALLOWED a superset of _HEARTBEAT_ALLOWED instead of duplicating values in the two constants. Change-Id: I47984469c1432e7fc7b4f1494b9f6c551c34672f
Unlike clean, deploy and verify steps, service steps cannot run automatically and thus do not have a usable notion of priority. It's not possible to provide a priority through the API but our validation code still requires it. This change gets rid of most priority handling for service steps, leaving only some foundation for future enhancements. Change-Id: I82aefc03a5c062b67e0f457612fe568399226dc8
Change-Id: I502be5613ffef7c2f51eafd0a10d5e9c5d5ec2a4
Change-Id: I58a27ec9e3646b143fc0874f033849056848c411
We ended up using two names for the same flag (and forgot it in one place completely). To not just fix the issue but also prevent it in the future, refactor asynchronous steps handling into a new helper module with constants and helper functions. I've settled on servicing_reboot as opposed to service_reboot because that's the value we currently set (but not read), so it provides better compatibility when backporting. Remove excessive mocking in the Redfish unit tests. Change-Id: I32b5f860b5d10864ce68f8d5f1dac3f76cd158d6
|
We need to wait for a couple more fixes to merge upstream before we can add them in. |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhjanders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rhjanders: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/hold cancel Let's move on with these ones, we can add other changes later if needed. |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit b5660c9
into
openshift:release-4.15
4 checks passed
|
Fix included in accepted release 4.15.0-0.nightly-2024-04-29-230005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.