Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE-2024-3727 GO-2024-2842: bump github.com/containers/image/v5 v5.30.2 #288

Merged
merged 2 commits into from
Oct 21, 2024
Merged

CVE-2024-3727 GO-2024-2842: bump github.com/containers/image/v5 v5.30.2 #288

merged 2 commits into from
Oct 21, 2024
+201 −289

Conversation

weshayutin
Copy link
Contributor

update containers/images for CVE

@weshayutin
CVE-2024-3727 GO-2024-2842: bump github.com/containers/image/v5 v5.30.2
81ce588 
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci-robot
Copy link

@weshayutin: No Jira issue with key CVE-2024 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

update containers/images for CVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@weshayutin: No Jira issue with key GO-2024 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

update containers/images for CVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kaovilai
kaovilai previously approved these changes Oct 21, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
shubham-pampattiwar
shubham-pampattiwar previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 548800a and 2 for PR HEAD 81ce588 in total

@kaovilai
Fix storage import vet failure.
6d16efc 
❯ go get github.com/containers/storage@v1.53.0
go: warning: github.com/moby/sys/user@v0.2.0: retracted by module author: Package github.com/moby/sys/user/userns was included in this module, but should've been a separate module; see moby/sys#140 (comment).
go: to switch to the latest unretracted version, run:
        go get github.com/moby/sys/user@latest
go: downgraded github.com/containers/storage v1.55.0 => v1.53.0

~/git/openshift-velero-plugin remotes/weshayutin/konveyor_dev_CVE-2024-3727*
❯ go mod tidy

~/git/openshift-velero-plugin remotes/weshayutin/konveyor_dev_CVE-2024-3727*
❯ go vet ./...

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai dismissed stale reviews from shubham-pampattiwar and themself via 6d16efc October 21, 2024 19:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 21, 2024

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kaovilai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 33f908a into openshift:master Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

Assignees

@kaovilai kaovilai

@shubham-pampattiwar shubham-pampattiwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weshayutin @openshift-ci-robot @kaovilai @shubham-pampattiwar