Add support for *List kinds #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
ping @willthames, first stab at *List support. |
|
Looks good so far. |
|
So this seems to be working properly, other than tests (which I'm working on now), is there anything you would change? Once this goes into a release I'm hoping for a PR to Ansible to get rid of any special casing for lists, I think they should be able to drop in seamlessly. |
openshift-ci-robot
added
size/L
fabianvf
force-pushed
the
list-kinds
branch
from
863f8aa
to
f3e045a
Compare
openshift-ci-robot
added
size/XL
fabianvf
added a commit
to fabianvf/openshift-restclient-python
that referenced
this pull request
Nov 5, 2018
* Add support for *List kinds * Update tests to support *List kinds (cherry picked from commit 89b5e8e)
willthames
pushed a commit
to willthames/openshift-restclient-python
that referenced
this pull request
Nov 22, 2018
* Add support for *List kinds * Update tests to support *List kinds
willthames
pushed a commit
to willthames/openshift-restclient-python
that referenced
this pull request
Nov 22, 2019
* Add support for *List kinds * Update tests to support *List kinds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #175 #209
Relates to ansible/ansible#42558