Adding environment variable support to BuildRequest #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcantrill
reviewed
Sep 27, 2016
| @@ -36,7 +35,10 @@ | |||
| private static final String REVISION_TYPE = REVISION + "." + TYPE; | |||
| private static final String TRIGGERED_BY = "triggeredBy"; | |||
| private static final String MESSAGE = "message"; | |||
|
|
|||
| private static final String ENV = "env"; | |||
| private static final String ENV_NAME = "name"; | |||
There was a problem hiding this comment.
NAME and VALUE are available as part of the interface implemented by KubernetesResource
There was a problem hiding this comment.
Fixed in latest push. Thanks.
|
[test] LGTM. @jupierce Test for BuildRequest to validate its set properly? |
|
Evaluated for javaclient test up to d4650b3 |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/253/) |
|
@jcantrill Added BuildRequestTest.java unit test. |
|
[merge] |
|
Evaluated for javaclient merge up to d4650b3 |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/254/) |
|
cool - thanks @jupierce and @jcantrill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support feature request: https://trello.com/c/Yl4qomsw/878-5-additional-jenkins-plugin-enhancement-requests-from-github
Adding environment variable support to restclient on which Jenkins plugin relies.
fyi @gabemontero