Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document imageLabels field in BuildConfigs #3015

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Document imageLabels field in BuildConfigs #3015

merged 1 commit into from
Oct 11, 2016

Conversation

mmilata
Copy link

@mmilata mmilata commented Oct 7, 2016

@mmilata mmilata mentioned this pull request Oct 7, 2016
Merged
3 tasks
bfallonf
bfallonf reviewed Oct 9, 2016
View reviewed changes
install_config/build_defaults_overrides.adoc

The `*BuildOverrides*` admission control plug-in allows administrators to
override a setting in a build, regardless of the value stored in the build. It
currently supports overriding the `*forcePull*` flag on a build strategy to
enforce always refreshing the local image during a build by pulling the image
from the registry. This ensures that a user can only build with an image that
they are allowed to pull.
they are allowed to pull. The plugin can also be configured to apply a set of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/plugin/plug-in

@bfallonf
Copy link

bfallonf commented Oct 9, 2016

@mmilata One typo-level fix then I'll merge. Thanks!

@bparees
Copy link
Contributor

bparees commented Oct 10, 2016

lgtm, pending @bfallonf's nit.

@mmilata mmilata force-pushed the arbitrary-image-labels branch from 66bead0 to e95386a Compare October 10, 2016 14:26
@mmilata
Copy link
Author

mmilata commented Oct 10, 2016

@bfallonf, should be fixed now.

@bfallonf
Copy link

Great! Thanks @mmilata . I'll merge away.

@bfallonf bfallonf added this to the Future Release milestone Oct 11, 2016
@bfallonf bfallonf merged commit 01ad862 into openshift:master Oct 11, 2016
@bfallonf
Copy link

[rev_history]
|xref:../dev_guide/builds.adoc#dev-guide-builds[Builds]
|Added example for custom build image label.
%
|xref:../install_config/build_defaults_overrides.adoc#install-config-build-defaults-overrides[Configuring Global Build Defaults and Overrides]
|Added image label example to build file examples.
%

@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.4 GA Jan 16, 2017
@adellape adellape modified the milestones: Staging, OCP 3.4 GA Feb 2, 2017
@adellape adellape modified the milestones: Staging, Temp, OCP 3.4 GA Feb 2, 2017
@adellape adellape modified the milestones: OCP 3.4 GA, Temp Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfallonf bfallonf bfallonf left review comments

Assignees
No one assigned
Labels
branch/dedicated branch/enterprise-3.4 branch/online
Projects
None yet
Milestone
OCP 3.4 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@mmilata @bfallonf @bparees @vikram-redhat @adellape