API-1863: Rebase 1.31 #458
Conversation
dinhxuanvu
force-pushed
the
rebase-1.31
branch
from
37d0128 to
b4b65e6
Compare
|
Waiting for openshift/kubernetes-apiserver#60 to merge first. |
dinhxuanvu
force-pushed
the
rebase-1.31
branch
from
0d62d7e to
8dda0b7
Compare
openshift-ci-robot
added
the
jira/valid-reference
|
@dinhxuanvu: This pull request references API-1820 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dinhxuanvu: This pull request references API-1863 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-cmd |
|
/retest-required |
|
/test e2e-aws-ovn-cmd |
1 similar comment
|
/test e2e-aws-ovn-cmd |
|
@p0lyn0mial @tkashem PTAL |
Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
rebase-1.31
branch
from
667e84f to
cd2704e
Compare
|
@p0lyn0mial @tkashem Updated and ready for final review. |
| k8s.io/utils v0.0.0-20230726121419-3b25d923346b | ||
| k8s.io/kubectl v0.31.1 | ||
| k8s.io/kubernetes v1.31.1 | ||
| k8s.io/utils v0.0.0-20240921022957-49e7df575cb6 |
There was a problem hiding this comment.
kube in 1.31 uses utils in v0.0.0-20240711033017-18e509b52bc8 version
https://github.com/kubernetes/kubernetes/blob/release-1.31/go.mod#L120C37-L120C49
why not to use the same version ?
There was a problem hiding this comment.
This is the result of go mod tidy/vendor cmd. I didn't manually change the k8s.io/utils. Only updated the dependencies with semver versioning.
| @@ -18,6 +19,7 @@ import ( | |||
| "k8s.io/client-go/rest" | |||
| "k8s.io/component-base/featuregate" | |||
| aggregatorapiserver "k8s.io/kube-aggregator/pkg/apiserver" | |||
| controlplaneadmission "k8s.io/kubernetes/pkg/controlplane/apiserver/admission" | |||
There was a problem hiding this comment.
I think this is okay, before we used k8s.io/kubernetes/pkg/kubeapiserver and now we will also be using k8s.io/kubernetes/pkg/controlplane
vendor/k8s.io/kubernetes/pkg/controlplane/apiserver/admission/config.go
Outdated
Show resolved
Hide resolved
| objectMetaShallowCopy := review.ObjectMeta | ||
| objectMetaShallowCopy.Namespace = "" | ||
| objectMetaShallowCopy.ManagedFields = nil | ||
| if !equality.Semantic.DeepEqual(metav1.ObjectMeta{}, objectMetaShallowCopy) { |
There was a problem hiding this comment.
I think this is also okay, since the resources are not persisted.
Signed-off-by: Vu Dinh <vudinh@outlook.com>
- update missing genclient:skipVerbs to authorization types - add validation to require empty ObjectMeta
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
rebase-1.31
branch
from
cd2704e to
65ff9ae
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test okd-scos-e2e-aws-ovn |
|
@dinhxuanvu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 53c5b3a
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-openshift-apiserver |
No description provided.