Adding deprecation warning for git based registries #4707

mohammedzee1000 · 2021-05-10T09:58:28Z

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

What type of PR is this?

/kind deprecation

What does this PR do / why we need it:
This PR adds deprecation warning for git based registries, whever they are created/listed/updated/used

Which issue(s) this PR fixes:

Fixes #4666

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

❯ odo registry list
NAME                       URL                             SECURE
DefaultDevfileRegistry     https://registry.devfile.io     No
❯ odo create nodejs
Devfile Object Validation
 ✓  Checking devfile existence [20878ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [36812ns]
Validation
 ✓  Validating if devfile name is correct [46943ns]

Please use `odo push` command to create the component with source deployed
❯ rm -rf ./devfile.yaml ./.odo
❯ odo registry add RegistryFromGitHub https://github.com/odo-devfiles/registry
 ⚠  Git based registries Deprecated  Please see https://github.com/openshift/odo/tree/main/docs/public/git-registry-deprecation.adoc
New registry successfully added
❯ odo registry list
NAME                       URL                                          SECURE
RegistryFromGitHub         https://github.com/odo-devfiles/registry     No
DefaultDevfileRegistry     https://registry.devfile.io                  No
 ⚠  Git based registries Deprecated  Please see https://github.com/openshift/odo/tree/main/docs/public/git-registry-deprecation.adoc
❯ rm -rf ./devfile.yaml ./.odo
❯ odo create nodejs --registry DefaultDevfileRegistry
Devfile Object Validation
 ✓  Checking devfile existence [71165ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [97543ns]
Validation
 ✓  Validating if devfile name is correct [125752ns]

Please use `odo push` command to create the component with source deployed
❯ odo create nodejs --registry RegistryFromGitHub
Devfile Object Validation
 ✓  Checking devfile existence [69482ns]
 ⚠  Git based registries Deprecated  Please see https://github.com/openshift/odo/tree/main/docs/public/git-registry-deprecation.adoc
 ✓  Creating a devfile component from registry: RegistryFromGitHub [220317ns]
Validation
 ✓  Validating if devfile name is correct [179669ns]

Please use `odo push` command to create the component with source deployed

openshift-ci · 2021-05-10T09:58:30Z

@mohammedzee1000: The label(s) kind/deprecation cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

What type of PR is this?

/kind deprecation

What does this PR do / why we need it:
This PR adds deprecation warning for git based registries, whever they are created/listed/updated/used

Which issue(s) this PR fixes:

Fixes #4666

PR acceptance criteria:

Unit test

Integration test

Documentation

Update changelog

I have read the test guidelines

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

girishramnani · 2021-05-10T10:57:09Z

tests/integration/devfile/cmd_devfile_registry_test.go


+	Context("when working with git based registries", func() {
+		It("should show deprecation warning when when the git based registry is used", func() {


shouldn't we clean up the registris that were added in these tests?

Registries are stored in the preference file and a new preference is created for each test. So I don't think this would be a problem

https://github.com/openshift/odo/blob/796bd2da69904f722b73b4c559b2cc96e18b3318/tests/helper/helper_generic.go#L300-L303

Anything else @girishramnani ?

mohammedzee1000 · 2021-05-11T04:58:17Z

Error is not related to code
/retest

mohammedzee1000 · 2021-05-12T05:03:17Z

Error seems unrelated to what is being changed
/retest

pkg/odo/cli/registry/util/util.go

pkg/odo/cli/component/create.go

pkg/log/status.go

feloy · 2021-05-12T08:07:38Z

/lgtm

mohammedzee1000 · 2021-05-12T10:27:48Z

It appears i did not notice the fact that sometimes raw.githubusercontent.com is also needed to be matched

feloy · 2021-05-12T10:58:41Z

/lgtm

mohammedzee1000 · 2021-05-12T14:20:51Z

Error unrelated to code
/retest

mohammedzee1000 · 2021-05-14T03:11:25Z

Approve plz

valaparthvi · 2021-05-17T10:17:43Z

pkg/odo/cli/registry/util/util.go

@@ -34,3 +35,11 @@ func IsSecure(registryName string) bool {

 	return isSecure
 }
+
+func IsGitBasedRegistry(url string) bool {
+	return strings.Contains(url, "github.com") || strings.Contains(url, "raw.githubusercontent.com")


Do we support any other git registries? Gitlab for example?

As @kadel said during planning, we DO NOT have any other official git registry, other than the hacky odo-devfiles/registry. In fact, the support for GitHub is basically the conversion of github.com to raw.githubusercontent.

We could technically show a warning for GitLab too though that would mean having to check support tens to hundreds of known git services. It will really hard to determine if a registry is git based if we want to be more generic as we will have to rely on git checks. .git is generally hidden on most online git services, which means we will have to go for attempting to clone the repo (which either means having git on the user's system or using golang based git library). Either will be overengineering not to mention us having to download the repo during clone.

So I am only showing a warning for GitHub right now.

valaparthvi · 2021-05-17T11:42:55Z

pkg/odo/cli/registry/util/util_test.go

+			registryURL: " https://registry.devfile.io",
+			want:        false,
+		},
+	}


This does not test raw.githubusercontent.com url. Or is it not required?

I guess we could add a test for that

valaparthvi · 2021-05-17T11:45:55Z

tests/integration/devfile/cmd_devfile_registry_test.go


+	Context("when working with git based registries", func() {
+		It("should show deprecation warning when when the git based registry is used", func() {


Typo.

It("should show deprecation warning ~~when~~ when the git based registry is used", func() {

fixing will push shortly

valaparthvi · 2021-05-17T11:49:35Z

tests/integration/devfile/cmd_devfile_registry_test.go

+			co = fmt.Sprintln(outstr, errstr)
+			helper.MatchAllInOutput(co, []string{deprecated, docLink})
+		})
+		It("should not show deprecation warning if git based registry is not used", func() {


I think `should not show deprecation warning if non-git-based registry is used" makes more sense than "should not show deprecation warning if git-based registry is not used".

Updating, will push shortly

valaparthvi

/lgtm

prietyc123 · 2021-05-18T10:01:17Z

tests/integration/devfile/cmd_devfile_registry_test.go

+			deprecated := "Deprecated"
+			docLink := "https://github.com/openshift/odo/tree/main/docs/public/git-registry-deprecation.adoc"
+			outstr, errstr := helper.CmdShouldPassIncludeErrStream("odo", "registry", "add", "RegistryFromGitHub", "https://github.com/odo-devfiles/registry")
+			co := fmt.Sprintln(outstr, errstr)


Is it required to print this? I mean shouldn't we convert it outstr, errstr := helper.CmdShouldPassIncludeErrStream("odo", "registry", "add", "RegistryFromGitHub", "https://github.com/odo-devfiles/registry") here itself.

It is not being printed. It is sprintf that is combining the stdout and stderr into one blob so I can do 1 comparison. I have noticed sometimes the string i am looking for printed using log.Deprecate can appear either in stdout or stderr. I do not know why this happens so i have to account for this behavior in the tests

It is not being printed.

Yes, my bad. Actually I saw this as Println 😄

prietyc123 · 2021-05-18T10:02:59Z

tests/integration/devfile/cmd_devfile_registry_test.go


+	Context("when working with git based registries", func() {
+		It("should show deprecation warning when the git based registry is used", func() {
+			deprecated := "Deprecated"


IMO we should have common steps in JustBeforeEach, no?

I am not sure if it makes a difference at this point as there is only one It block

I am not sure if it makes a difference at this point as there is only one It block

Only one you mean? I guess there are two but correct me if I am wrong.

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

mohammedzee1000 · 2021-05-18T11:33:04Z

Seems to be some sort of flake. Recording and retesting

INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] !!!!!!!!!!!!!!!!!!!!        
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Running unit tests          
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] !!!!!!!!!!!!!!!!!!!!        
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] go test   github.com/openshift/odo/cmd/cli-doc github.com/openshift/odo/cmd/odo github.com/openshift/odo/pkg/application github.com/openshift/odo/pkg/application/labels github.com/openshift/odo/pkg/auth github.com/openshift/odo/pkg/catalog github.com/openshift/odo/pkg/component github.com/openshift/odo/pkg/component/labels github.com/openshift/odo/pkg/config github.com/openshift/odo/pkg/debug github.com/openshift/odo/pkg/devfile/adapters github.com/openshift/odo/pkg/devfile/adapters/common github.com/openshift/odo/pkg/devfile/adapters/docker github.com/openshift/odo/pkg/devfile/adapters/docker/component github.com/openshift/odo/pkg/devfile/adapters/docker/storage github.com/openshift/odo/pkg/devfile/adapters/docker/utils github.com/openshift/odo/pkg/devfile/adapters/kubernetes github.com/openshift/odo/pkg/devfile/adapters/kubernetes/component github.com/openshift/odo/pkg/devfile/adapters/kubernetes/storage github.com/openshift/odo/pkg/devfile/adapters/kubernetes/utils github.com/openshift/odo/pkg/devfile/convert github.com/openshift/odo/pkg/devfile/validate github.com/openshift/odo/pkg/envinfo github.com/openshift/odo/pkg/kclient github.com/openshift/odo/pkg/kclient/fake github.com/openshift/odo/pkg/lclient github.com/openshift/odo/pkg/localConfigProvider github.com/openshift/odo/pkg/log github.com/openshift/odo/pkg/log/fidget github.com/openshift/odo/pkg/machineoutput github.com/openshift/odo/pkg/notify github.com/openshift/odo/pkg/occlient github.com/openshift/odo/pkg/odo/cli github.com/openshift/odo/pkg/odo/cli/application github.com/openshift/odo/pkg/odo/cli/catalog github.com/openshift/odo/pkg/odo/cli/catalog/describe github.com/openshift/odo/pkg/odo/cli/catalog/list github.com/openshift/odo/pkg/odo/cli/catalog/search github.com/openshift/odo/pkg/odo/cli/catalog/util github.com/openshift/odo/pkg/odo/cli/component github.com/openshift/odo/pkg/odo/cli/component/ui github.com/openshift/odo/pkg/odo/cli/config github.com/openshift/odo/pkg/odo/cli/debug github.com/openshift/odo/pkg/odo/cli/env github.com/openshift/odo/pkg/odo/cli/login github.com/openshift/odo/pkg/odo/cli/logout github.com/openshift/odo/pkg/odo/cli/plugins github.com/openshift/odo/pkg/odo/cli/preference github.com/openshift/odo/pkg/odo/cli/project github.com/openshift/odo/pkg/odo/cli/registry github.com/openshift/odo/pkg/odo/cli/registry/util github.com/openshift/odo/pkg/odo/cli/service github.com/openshift/odo/pkg/odo/cli/service/ui github.com/openshift/odo/pkg/odo/cli/storage github.com/openshift/odo/pkg/odo/cli/telemetry github.com/openshift/odo/pkg/odo/cli/ui github.com/openshift/odo/pkg/odo/cli/url github.com/openshift/odo/pkg/odo/cli/utils github.com/openshift/odo/pkg/odo/cli/version github.com/openshift/odo/pkg/odo/genericclioptions github.com/openshift/odo/pkg/odo/util github.com/openshift/odo/pkg/odo/util/completion github.com/openshift/odo/pkg/odo/util/experimental github.com/openshift/odo/pkg/odo/util/validation github.com/openshift/odo/pkg/preference github.com/openshift/odo/pkg/project github.com/openshift/odo/pkg/secret github.com/openshift/odo/pkg/segment github.com/openshift/odo/pkg/service github.com/openshift/odo/pkg/storage github.com/openshift/odo/pkg/storage/labels github.com/openshift/odo/pkg/sync github.com/openshift/odo/pkg/sync/mock github.com/openshift/odo/pkg/testingutil github.com/openshift/odo/pkg/testingutil/filesystem github.com/openshift/odo/pkg/url github.com/openshift/odo/pkg/url/labels github.com/openshift/odo/pkg/util github.com/openshift/odo/pkg/version github.com/openshift/odo/pkg/watch 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/cmd/cli-doc	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/cmd/odo	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/application	0.183s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/application/labels	0.689s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/auth	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/catalog	0.177s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/component	0.220s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/component/labels	0.835s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/config	0.451s 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/debug	0.639s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters	0.202s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/common	0.584s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/devfile/adapters/docker	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/docker/component	0.252s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/docker/storage	0.694s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/docker/utils	0.661s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/devfile/adapters/kubernetes	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/kubernetes/component	5.362s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/kubernetes/storage	0.305s 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/adapters/kubernetes/utils	0.157s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/devfile/convert	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/devfile/validate	0.641s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/envinfo	0.155s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/kclient	3.219s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/kclient/fake	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/lclient	0.810s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/localConfigProvider	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/log	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/log/fidget	[no test files] 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/machineoutput	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/notify	0.617s [no tests to run] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/occlient	3.205s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/application	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/catalog	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/catalog/describe	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/catalog/list	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/catalog/search	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/catalog/util	0.185s 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/component	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/component/ui	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/config	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/debug	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/env	0.170s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/login	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/logout	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/plugins	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/preference	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/project	[no test files] 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/registry	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/registry/util	0.633s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/service	0.229s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/service/ui	0.194s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/storage	0.160s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/telemetry	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/ui	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/url	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/cli/utils	0.225s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/cli/version	[no test files] 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/odo/genericclioptions	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/util	0.171s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/util/completion	0.235s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/util/experimental	0.726s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/odo/util/validation	0.579s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/preference	0.867s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/project	0.260s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/secret	0.438s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/segment	0.759s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/service	0.255s 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/storage	0.286s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/storage/labels	0.691s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/sync	0.322s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/sync/mock	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/testingutil	0.274s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/testingutil/filesystem	[no test files] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/url	0.346s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/url/labels	0.757s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ok  	github.com/openshift/odo/pkg/util	0.783s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ?   	github.com/openshift/odo/pkg/version	[no test files] 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Waiting for something to change in C:\Users\Admin\fabric8-analytics-license-analysis462151403 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis462151403\__init__.py291132514 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis462151403\src244532046\read_licenses.py470388893 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Pushing files...            
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Component is running in debug mode 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Please start port-forwarding in a different terminal 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Waiting for something to change in C:\Users\Admin\fabric8-analytics-license-analysis249886423 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis249886423\__init__.py527327518 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis249886423\src233835082\read_licenses.py968878825 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Pushing files...            
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Waiting for something to change in C:\Users\Admin\fabric8-analytics-license-analysis083143939 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis083143939\__init__.py140217626 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis083143939\src742756486\read_licenses.py684901749 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Pushing files...            
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Waiting for something to change in C:\Users\Admin\fabric8-analytics-license-analysis026297199 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis026297199\__init__.py821976150 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] File C:\Users\Admin\fabric8-analytics-license-analysis026297199\src347356162\read_licenses.py210116673 changed 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] Pushing files...            
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] panic: test timed out after 10m0s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 15 [running]:     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.(*M).startAlarm.func1() 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1628 +0xe6 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by time.goFunc      
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/time/sleep.go:167 +0x4b 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 1 [chan receive, 10 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.(*T).Run(0xc000584600, 0x235045f, 0x10, 0x2455608, 0xd57ccd) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1179 +0x3be 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.runTests.func1(0xc000584480) 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1449 +0x7f 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.tRunner(0xc000584480, 0xc0000abde0) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1127 +0xef 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.runTests(0xc0003b5d40, 0x30c2e00, 0x1, 0x1, 0xc02104afb8ca5804, 0x8bb58cf7bd, 0x30e6440, 0xcbe570) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1447 +0x2eb 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.(*M).Run(0xc000497b00, 0x0) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1357 +0x24e 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] main.main()                 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	_testmain.go:43 +0x145     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 35 [chan receive]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] k8s.io/klog/v2.(*loggingT).flushDaemon(0x30e6960) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/vendor/k8s.io/klog/v2/klog.go:1169 +0x92 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by k8s.io/klog/v2.init.0 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/vendor/k8s.io/klog/v2/klog.go:417 +0xe5 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 36 [chan receive]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] k8s.io/klog.(*loggingT).flushDaemon(0x30e6880) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/vendor/k8s.io/klog/klog.go:1010 +0x92 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by k8s.io/klog.init.0 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/vendor/k8s.io/klog/klog.go:411 +0xdd 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 6 [chan receive, 9 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.(*T).Run(0xc00004f200, 0xc000596850, 0x6c, 0xc00059cad0, 0x235fa4f) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1179 +0x3be 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.TestWatchAndPush(0xc000584600) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch_test.go:754 +0xb4c 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.tRunner(0xc000584600, 0x2455608) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1127 +0xef 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by testing.(*T).Run 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1178 +0x397 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 20 [chan send, 9 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.commonChecks(0xc00003f900, 0x3a, 0xc0000593e0, 0x1, 0x1, 0xc000430390, 0x1, 0x1, 0xc0000d84c0, 0x3, ...) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch_test.go:197 +0x289 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.mockDevFilePush(0xc00003f900, 0x3a, 0xc0000593e0, 0x1, 0x1, 0xc000430390, 0x1, 0x1, 0xc0000d84c0, 0x3, ...) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch_test.go:136 +0x45b 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.WatchAndPush(0xc0000f0000, 0x2570700, 0xc00013c008, 0x23509bf, 0x10, 0x0, 0x0, 0xc00003f900, 0x3a, 0xc0000d84c0, ...) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:359 +0xabb 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.TestWatchAndPush.func1(0xc00004f200) 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch_test.go:864 +0x638 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] testing.tRunner(0xc00004f200, 0xc00059cad0) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1127 +0xef 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by testing.(*T).Run 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/testing/testing.go:1178 +0x397 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 10 [semacquire, 9 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.runtime_SemacquireMutex(0xc00021db34, 0xc0003c3d00, 0x1) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/runtime/sema.go:71 +0x4e 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).lockSlow(0xc00021db30) 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:138 +0x10f 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).Lock(...)     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:81 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.WatchAndPush.func1(0xc00050c790, 0xc00021db30, 0xc0000595a0, 0xc00045bb80, 0xc0003de280, 0xc0003de220, 0xc00021db38, 0xc0003de240) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:198 +0xf05 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by github.com/openshift/odo/pkg/watch.WatchAndPush 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:187 +0x3da 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 14 [semacquire, 9 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.runtime_SemacquireMutex(0xc0000368ec, 0xc000041700, 0x1) 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/runtime/sema.go:71 +0x4e 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).lockSlow(0xc0000368e8) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:138 +0x10f 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).Lock(...)     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:81 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.WatchAndPush.func1(0xc00050cd10, 0xc0000368e8, 0xc0001fea90, 0xc0005d3500, 0xc000420800, 0xc0004207c0, 0xc0000368f0, 0xc0004207e0) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:198 +0xf05 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by github.com/openshift/odo/pkg/watch.WatchAndPush 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:187 +0x3da 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 53 [semacquire, 9 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.runtime_SemacquireMutex(0xc00021cedc, 0xc00024f900, 0x1) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/runtime/sema.go:71 +0x4e 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).lockSlow(0xc00021ced8) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:138 +0x10f 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).Lock(...)     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:81 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.WatchAndPush.func1(0xc00015c8f0, 0xc00021ced8, 0xc000058a60, 0xc000147600, 0xc0003de9c0, 0xc0003de960, 0xc00021cee0, 0xc0003de980) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:198 +0xf05 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by github.com/openshift/odo/pkg/watch.WatchAndPush 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:187 +0x3da 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 22 [syscall, 9 minutes, locked to thread]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] syscall.Syscall6(0x7ffe34366620, 0x5, 0x1d8, 0xc000333d10, 0xc000333d14, 0xc000333d78, 0xffffffff, 0x0, 0x0, 0x0, ...) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/runtime/syscall_windows.go:201 +0xf2 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] syscall.GetQueuedCompletionStatus(0x1d8, 0xc000333d10, 0xc000333d14, 0xc000333d78, 0xffffffff, 0x0, 0x0) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/syscall/zsyscall_windows.go:556 +0xd7 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/fsnotify/fsnotify.(*Watcher).readEvents(0xc0000d8500) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/vendor/github.com/fsnotify/fsnotify/windows.go:381 +0xa5 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by github.com/fsnotify/fsnotify.NewWatcher 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/vendor/github.com/fsnotify/fsnotify/windows.go:46 +0x1f2 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10]                             
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] goroutine 23 [semacquire, 9 minutes]: 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.runtime_SemacquireMutex(0xc000110afc, 0xc00044bd00, 0x1) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/runtime/sema.go:71 +0x4e 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).lockSlow(0xc000110af8) 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:138 +0x10f 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] sync.(*Mutex).Lock(...)     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	c:/go/src/sync/mutex.go:81 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] github.com/openshift/odo/pkg/watch.WatchAndPush.func1(0xc0000f2580, 0xc000110af8, 0xc00059cd90, 0xc0000d8500, 0xc000406c60, 0xc000406c00, 0xc000110b00, 0xc000406c20) 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:198 +0xf05 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] created by github.com/openshift/odo/pkg/watch.WatchAndPush 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] 	C:/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/pkg/watch/watch.go:187 +0x3da 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] FAIL	github.com/openshift/odo/pkg/watch	600.129s 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] FAIL                        
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ shout 'Setting up some stuff' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ set +x                   
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ mkdir bin artifacts      
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ pwd                     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ export GOBIN=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/bin 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ GOBIN=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/bin 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ pwd                     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ export KUBECONFIG=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/config 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ KUBECONFIG=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/config 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ pwd                     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ export ARTIFACT_DIR=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/artifacts 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ ARTIFACT_DIR=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/artifacts 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ export CUSTOM_HOMEDIR=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/artifacts 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ CUSTOM_HOMEDIR=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/artifacts 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ pwd                     
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ export GOCACHE=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/.gocache 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ GOCACHE=/cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/.gocache 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ mkdir /cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/.gocache 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ SCRIPT_IDENTITY=-ENV:SCRIPT_IDENTITY:REDACTED- 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ [[ windows == \w\i\n\d\o\w\s ]] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ shout 'Setting GOBIN for windows' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ set +x                   
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ cygpath -pw /cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/bin 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ GOBIN='C:\Users\Admin\amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707\repo\bin' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ cygpath -pw /cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/.gocache 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ GOCACHE='C:\Users\Admin\amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707\repo\.gocache' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] +++ cygpath -pw /cygdrive/c/Users/Admin/amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707/repo/artifacts 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ CUSTOM_HOMEDIR='C:\Users\Admin\amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707\repo\artifacts' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ shout 'Setting PATH'     
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ set +x                   
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ export 'PATH=/bin:/cygdrive/c/WINDOWS/system32:/cygdrive/c/WINDOWS:/cygdrive/c/WINDOWS/System32/Wbem:/cygdrive/c/WINDOWS/System32/WindowsPowerShell/v1.0:/cygdrive/c/Go/bin:/cygdrive/c/Program Files/Git/cmd:/cygdrive/c/WINDOWS/System32/OpenSSH:/cygdrive/c/TDM-GCC-64/bin:/cygdrive/c/Users/cyg_server/AppData/Local/Microsoft/WindowsApps:C:\Users\Admin\amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707\repo\bin' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ PATH='/bin:/cygdrive/c/WINDOWS/system32:/cygdrive/c/WINDOWS:/cygdrive/c/WINDOWS/System32/Wbem:/cygdrive/c/WINDOWS/System32/WindowsPowerShell/v1.0:/cygdrive/c/Go/bin:/cygdrive/c/Program Files/Git/cmd:/cygdrive/c/WINDOWS/System32/OpenSSH:/cygdrive/c/TDM-GCC-64/bin:/cygdrive/c/Users/cyg_server/AppData/Local/Microsoft/WindowsApps:C:\Users\Admin\amqp_ci_rcv_odo-windows-unit-pr-build_PR_4707\repo\bin' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] + . ./scripts/run_script_unit.sh 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ shout 'Running unit tests' 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ set +x                   
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ [[ windows == \w\i\n\d\o\w\s ]] 
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ GOFLAGS=-mod=vendor      
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] ++ make test-windows        
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] make: *** [Makefile:155: test-windows] Error 1 
INFO[2021-05-18T10:47:40Z]                                              
INFO[2021-05-18T10:47:40Z] [ssh:Windows 10] !!!run failed, skipping!!!

/test psi-unit-test-windows

prietyc123 · 2021-05-18T11:54:28Z

/lgtm

kadel · 2021-05-19T10:41:31Z

/approve

openshift-ci · 2021-05-19T10:41:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 10, 2021

openshift-ci bot requested review from dharmit and rnapoles-rh May 10, 2021 09:58

mohammedzee1000 force-pushed the deprecate_git_registry branch from d0aaa10 to ab1c126 Compare May 10, 2021 10:36

mohammedzee1000 changed the title ~~WIP Adding deprecation warning for git based registries~~ Adding deprecation warning for git based registries May 10, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 10, 2021

girishramnani reviewed May 10, 2021

View reviewed changes

mohammedzee1000 force-pushed the deprecate_git_registry branch from 5b0487a to 5f07049 Compare May 11, 2021 05:08

feloy reviewed May 12, 2021

View reviewed changes

pkg/odo/cli/registry/util/util.go Outdated Show resolved Hide resolved

pkg/odo/cli/component/create.go Outdated Show resolved Hide resolved

pkg/log/status.go Outdated Show resolved Hide resolved

openshift-ci bot assigned feloy May 12, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. and removed lgtm Indicates that a PR is ready to be merged. Required by Prow. labels May 12, 2021

mohammedzee1000 requested a review from feloy May 12, 2021 10:27

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 12, 2021

feloy approved these changes May 12, 2021

View reviewed changes

valaparthvi reviewed May 17, 2021

View reviewed changes

mohammedzee1000 force-pushed the deprecate_git_registry branch from 99ed836 to 3c1add2 Compare May 17, 2021 12:04

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 17, 2021

valaparthvi approved these changes May 17, 2021

View reviewed changes

openshift-ci bot assigned valaparthvi May 17, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 17, 2021

prietyc123 suggested changes May 18, 2021

View reviewed changes

openshift-ci bot assigned prietyc123 May 18, 2021

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 18, 2021

mohammedzee1000 added 12 commits May 18, 2021 15:57

Adding deprecation warning for git based registries

bedb653

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Adding tests for deprecation warning for git based registry

d2a5c38

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Adding changelog

853d27f

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Fixing gofmt

56ff9d3

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Fixing gofmt

7774689

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Moving color sprint funcions inside if block

ef37384

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Removing unnessasary comment

c288bc7

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Expanding url matching for github to github.com

e1a12e5

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Combining outputs of out and err for matching

25738f2

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Adding raw githubusercontent to git registry check

a71b338

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Fixing as per comments by @valaparthvi

c5f04fb

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Moving declarations to just before each

4144b0a

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

mohammedzee1000 force-pushed the deprecate_git_registry branch from 3c1add2 to 4144b0a Compare May 18, 2021 10:28

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 18, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 19, 2021

openshift-merge-robot merged commit 44d12d3 into redhat-developer:main May 19, 2021

kadel mentioned this pull request Mar 21, 2022

Remove support for github based devfile registries #5579

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding deprecation warning for git based registries #4707

Adding deprecation warning for git based registries #4707

mohammedzee1000 commented May 10, 2021 •

edited

Loading

openshift-ci bot commented May 10, 2021

girishramnani May 10, 2021

mohammedzee1000 May 10, 2021

mohammedzee1000 May 12, 2021

mohammedzee1000 commented May 11, 2021

mohammedzee1000 commented May 12, 2021

feloy commented May 12, 2021

mohammedzee1000 commented May 12, 2021

feloy commented May 12, 2021

mohammedzee1000 commented May 12, 2021

mohammedzee1000 commented May 14, 2021

valaparthvi May 17, 2021

mohammedzee1000 May 17, 2021 •

edited

Loading

valaparthvi May 17, 2021 •

edited

Loading

mohammedzee1000 May 17, 2021

valaparthvi May 17, 2021 •

edited

Loading

mohammedzee1000 May 17, 2021

valaparthvi May 17, 2021 •

edited

Loading

mohammedzee1000 May 17, 2021

valaparthvi left a comment

prietyc123 May 18, 2021 •

edited

Loading

mohammedzee1000 May 18, 2021 •

edited

Loading

prietyc123 May 18, 2021

prietyc123 May 18, 2021

mohammedzee1000 May 18, 2021

prietyc123 May 18, 2021

mohammedzee1000 commented May 18, 2021

prietyc123 commented May 18, 2021

kadel commented May 19, 2021

openshift-ci bot commented May 19, 2021


		Context("when working with git based registries", func() {
		It("should show deprecation warning when when the git based registry is used", func() {

Adding deprecation warning for git based registries #4707

Adding deprecation warning for git based registries #4707

Conversation

mohammedzee1000 commented May 10, 2021 • edited Loading

openshift-ci bot commented May 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohammedzee1000 commented May 11, 2021

mohammedzee1000 commented May 12, 2021

feloy commented May 12, 2021

mohammedzee1000 commented May 12, 2021

feloy commented May 12, 2021

mohammedzee1000 commented May 12, 2021

mohammedzee1000 commented May 14, 2021

Choose a reason for hiding this comment

mohammedzee1000 May 17, 2021 • edited Loading

Choose a reason for hiding this comment

valaparthvi May 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valaparthvi May 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valaparthvi May 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valaparthvi left a comment

Choose a reason for hiding this comment

prietyc123 May 18, 2021 • edited Loading

Choose a reason for hiding this comment

mohammedzee1000 May 18, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohammedzee1000 commented May 18, 2021

prietyc123 commented May 18, 2021

kadel commented May 19, 2021

openshift-ci bot commented May 19, 2021

mohammedzee1000 commented May 10, 2021 •

edited

Loading

mohammedzee1000 May 17, 2021 •

edited

Loading

valaparthvi May 17, 2021 •

edited

Loading

valaparthvi May 17, 2021 •

edited

Loading

valaparthvi May 17, 2021 •

edited

Loading

prietyc123 May 18, 2021 •

edited

Loading

mohammedzee1000 May 18, 2021 •

edited

Loading