Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCI-based registry migration #4702

Merged

Conversation

GeekArthur
Copy link
Contributor

Signed-off-by: jingfu wang jingfwan@redhat.com

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR ensures the OCI-based registry auto migration only migrates the old default registry.

Which issue(s) this PR fixes:
Related issue: #4504

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

Signed-off-by: jingfu wang <jingfwan@redhat.com>
@GeekArthur GeekArthur requested a review from kadel May 7, 2021 15:38
@GeekArthur GeekArthur self-assigned this May 7, 2021
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 7, 2021
@josephca
Copy link
Contributor

josephca commented May 7, 2021

/retest

@GeekArthur
Copy link
Contributor Author

@kadel Mind quickly reviewing this PR? Thanks.

@kadel
Copy link
Member

kadel commented May 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 10, 2021
@kadel
Copy link
Member

kadel commented May 10, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GeekArthur, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7f998e4 into redhat-developer:main May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants