Removes invalid endpoints from the devfile on triggering url create.

[mik-dass]

What type of PR is this?

/kind bug

What does does this PR do / why we need it:

It also modifies the error messages when no port is provided.

Which issue(s) this PR fixes:

Fixes #4493

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

• Download a devfile with an existing URL endpoint and no host information should exist on the env file.
• Trigger odo url create on a kubernetes cluster.
• The endpoint which came with the devfile should have host information in the env file.

[dharmit]

/hold

@mik-dass @kadel @scottkurz

There's no response on the discussion on the original issue. While discussing this issue on the planning call, it was the most unclear issue! Everyone was confused about what's wrong with the current behaviour and what's the expectation.

I request more clarity around these matters before starting code.

[mik-dass]

ERRO[2021-04-21T16:32:23Z] [ssh:Fedora 32] !!!Attempt 3!!!              
ERRO[2021-04-21T16:32:23Z] [ssh:Fedora 32] !!!attempt failed due to executor error!!! 
ERRO[2021-04-21T16:32:23Z]  - failed to initialize executor failed to initialize ssh client dial tcp -IP REDACTED-:22: connect: connection timed out

/retest

[dharmit]

/hold cancel

[dharmit]

@mik-dass @kadel this one's going to require documentation for odo.dev. IIUC, we've discussed a bunch of scenarios and made changes based on this. At the moment, I don't see a dedicated page to explain odo url behaviour on odo.dev. IMO, it makes sense to have one considering the various scenarios you folks discussed on #4493.

[scottkurz]

This looks good to me !

For the devfile used in https://github.com/OpenLiberty/application-stack-intro/blob/main/devfile.yaml which has a single endpoint:

        - exposure: public
          path: /
          name: ep1
          targetPort: 9080
          protocol: http

the odo url create --host $(minikube ip).nip.io creates URL (in odo env.yaml)

Url:

• Name: ep1
  Host: 192.168.39.79.nip.io
  Kind: ingress

and without updating the devfile.

Follow-up

Reminding myself we need to go back and update this getting started doc:
https://odo.dev/docs/deploying-a-devfile-using-odo/#deploying-an-open-liberty-application-to-an-openshift--kubernetes-cluster
since it works around the existing behavior.

It's not like we try to explain odo url create in detail but the exact command text will be a bit affected by the new URL

I'll keep an eye on this or let me know, and I can change the doc then.

[kadel]

this doesn't seem to be used anywhere

[mik-dass]

I have rebased the PR.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kadel]

original devfile

      endpoints:
        - name: http-3000
          targetPort: 3000

after running odo url create using openshift cluster
I ended up with duplicate endpoints for port 3000

    endpoints:
    - name: http-3000
      targetPort: 3000
    - exposure: public
      name: nodejs-nodejs-ex-rshg-3000
      path: /
      protocol: http
      targetPort: 3000

My expectation was that in this case odo url create wouldn't change anything in devfile.

[mik-dass]

after running odo url create using openshift cluster
I ended up with duplicate endpoints for port 3000

Since http-3000 is valid on a openshift cluster as it doesn't require any host info in the env file, a new endpoint was added.

[kadel]

after running odo url create using openshift cluster
I ended up with duplicate endpoints for port 3000

Since http-3000 is valid on a openshift cluster as it doesn't require any host info in the env file, a new endpoint was added.

hmm, I can see. That is also a valid angle. ok.

[kadel]

/retest

[kadel]

/lgtm

[kadel]

/hold

[kadel]

/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[mik-dass]

INFO[2021-05-06T09:49:49Z] • Failure [138.427 seconds]     
INFO[2021-05-06T09:49:49Z] odo supported images e2e tests               
INFO[2021-05-06T09:49:49Z] /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:18 
INFO[2021-05-06T09:49:49Z]   odo supported private registry images deployment 
INFO[2021-05-06T09:49:49Z]   /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:120 
INFO[2021-05-06T09:49:49Z]     Should be able to verify the openjdk-11-rhel8 image [It] 
skipped 1848 lines unfold_more

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kadel]

/lgtm

[openshift-ci]

@mik-dass: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/psi-openshift-integration-e2e	6d086e9	link	/test psi-openshift-integration-e2e
ci/prow/psi-minishift-integration-e2e	6d086e9	link	/test psi-minishift-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.