Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oadp-1.3] fix: 4.15 CI error with restart policy #1437

Conversation

mateusoliveira43
Copy link
Contributor

Why the changes were made

Fix CI for OCP 4.15+ as done in #1365

How to test the changes made

Check CI logs, no restartPolicy errors should happen.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@kaovilai
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@weshayutin
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f36ca8c and 2 for PR HEAD a186e18 in total

@mateusoliveira43
Copy link
Contributor Author

Majority of failures were due to "The API Server may have been down" (and I also saw our normal flake and error updating status for volume snapshot content snapcontent, which is planed to be fixed in the future). Should we override?

@kaovilai
Copy link
Member

Think it's safe to override. Unlikely to introduce bugs in this PR.

Copy link

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member

These API server down flakes are resolvable via openshift/velero#324

@kaovilai
Copy link
Member

/override ci/prow/4.13-e2e-test-aws
/override ci/prow/4.14-e2e-test-aws
/override ci/prow/4.15-e2e-test-aws

Copy link

openshift-ci bot commented Jun 27, 2024

@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.13-e2e-test-aws, ci/prow/4.14-e2e-test-aws, ci/prow/4.15-e2e-test-aws

In response to this:

/override ci/prow/4.13-e2e-test-aws
/override ci/prow/4.14-e2e-test-aws
/override ci/prow/4.15-e2e-test-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jun 27, 2024

@mateusoliveira43: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.14-e2e-test-aws a186e18 link true /test 4.14-e2e-test-aws
ci/prow/4.15-e2e-test-aws a186e18 link true /test 4.15-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1f36d21 into openshift:oadp-1.3 Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants