-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oadp-1.3] fix: 4.15 CI error with restart policy #1437
[oadp-1.3] fix: 4.15 CI error with restart policy #1437
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/retest |
Majority of failures were due to "The API Server may have been down" (and I also saw our normal flake and error updating status for volume snapshot content snapcontent, which is planed to be fixed in the future). Should we override? |
Think it's safe to override. Unlikely to introduce bugs in this PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These API server down flakes are resolvable via openshift/velero#324 |
/override ci/prow/4.13-e2e-test-aws |
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.13-e2e-test-aws, ci/prow/4.14-e2e-test-aws, ci/prow/4.15-e2e-test-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mateusoliveira43: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why the changes were made
Fix CI for OCP 4.15+ as done in #1365
How to test the changes made
Check CI logs, no restartPolicy errors should happen.