Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oadp-1.3] bump kubevirt to 0.6.2 #1436

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[oadp-1.3] bump kubevirt to 0.6.2 #1436

merged 1 commit into from
Jun 28, 2024

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jun 20, 2024 •
edited
Loading

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Why the changes were made
We're using a VERY old kubevirt plugin in prow tests and dev setup

How to test the changes made
make deploy-olm and check the deployment

@openshift-ci openshift-ci bot requested review from eemcmullan and sseago June 20, 2024 18:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
weshayutin
weshayutin reviewed Jun 20, 2024
View reviewed changes
pkg/common/common.go Outdated Show resolved Hide resolved
@kaovilai
bump kubevirt to 0.6.2
45198e8 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
weshayutin
weshayutin approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
rayfordj
rayfordj approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, rayfordj, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,rayfordj,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rayfordj
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f36ca8c and 2 for PR HEAD 45198e8 in total

@mateusoliveira43
Copy link
Contributor

I saw some errors I never saw: api server may have been down. Should we investigate that?

@mateusoliveira43 mateusoliveira43 changed the title bump kubevirt to 0.6.2 [oadp-1.3] bump kubevirt to 0.6.2 Jun 21, 2024
@kaovilai
Copy link
Member Author

Error came from openshift/velero#315

@weshayutin
Copy link
Contributor

Error came from openshift/velero#315

uh oh.. Tiger please investigate this.

@kaovilai
Copy link
Member Author

Takes about 20 sec after creation to fail.

2024/06/20 21:04:31 Creating backup mysql-csi-e2e-90f0f6b7-2f48-11ef-a75a-0a580a812821 for case mysql-csi-e2e
2024/06/20 21:04:41 backup phase: InProgress
2024/06/20 21:04:52 backup phase: Failed

@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

fix fyi: openshift/velero#324

mateusoliveira43
mateusoliveira43 requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also had the same problem here: If I add kubevirt plugin in DPA, velero container never succeeds with Init:CrashLoopBackOff with kubevirt plugin restarting 6 times in 10 minutes

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1f36d21 and 1 for PR HEAD 45198e8 in total

@kaovilai
Copy link
Member Author

/hold for openshift/velero#324

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@kaovilai
Copy link
Member Author

/retest
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@kaovilai
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 28, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a2ce33b into openshift:oadp-1.3 Jun 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 mateusoliveira43 requested changes

@weshayutin weshayutin weshayutin approved these changes

@rayfordj rayfordj rayfordj approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

@sseago sseago Awaiting requested review from sseago

Assignees

@weshayutin weshayutin

@rayfordj rayfordj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaovilai @rayfordj @openshift-ci-robot @mateusoliveira43 @weshayutin @shubham-pampattiwar