Skip to content

Konflux: fbc fixes #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged

Conversation

AnnaZivkovic
Copy link
Contributor

@AnnaZivkovic AnnaZivkovic commented Apr 15, 2025

Fix 4.17 push yaml versioning
Update references to match 4.18
Fix folder naming to match the following formatting https://github.com/openshift/multiarch-tuning-operator/fbc/fbc-4-18

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@AnnaZivkovic AnnaZivkovic changed the title WIP Konflux: fbc test updates Konflux: fbc fixes Apr 15, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@AnnaZivkovic
Copy link
Contributor Author

/retest

1 similar comment
@AnnaZivkovic
Copy link
Contributor Author

/retest

@AnnaZivkovic AnnaZivkovic force-pushed the fbc-test-updates branch 13 times, most recently from a8a0589 to e328b42 Compare April 16, 2025 21:08
@AnnaZivkovic AnnaZivkovic force-pushed the fbc-test-updates branch 2 times, most recently from 5c00f5d to eec8168 Compare April 16, 2025 22:02
@AnnaZivkovic
Copy link
Contributor Author

/retest

…ments for dockerfile

Add build arguments for dockerfile
update naming scheme to include a v
@AnnaZivkovic
Copy link
Contributor Author

/retest

This pr was passing all tests
Testing if konflux will get task clone-repository has the status "Failed" for fbc:

Error response from registry: recognizable error message not found: PUT "https://quay.io/v2/redhat-user-workloads/multiarch-tuning-ope-tenant/multiarch-tuning-operator/multiarch-tuning-operator/blobs/uploads/8a60116c-eb56-4892-96bb-6afa92eb0081?digest=sha256%3A5e1439007f226bd591e3c3a854868829de82772c0738e43103bbd242a979cae7": response status code 403: Forbidden
Command exited with non-zero status 1

@aleskandro
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
Copy link

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2025
@aleskandro
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit d2cdfb0 into openshift:fbc Apr 22, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants