Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setupEtcdEnvKey to images.json #1180

Closed
wants to merge 1 commit into from
Closed

add setupEtcdEnvKey to images.json #1180

wants to merge 1 commit into from

Conversation

rphillips
Copy link
Contributor

- What I did
setupEtcdEnvKey is referenced in the images.json file and is missing from the ConfigMap. images.json is generated from the ConfigMap.

I checked release-4.2 and this will need backported as well. We also need @runcom's fix #1177

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
To complete the pull request process, please assign lorbuschris
You can assign the PR to them by writing /assign @lorbuschris in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips rphillips closed this Oct 16, 2019
@openshift-ci-robot
Copy link
Contributor

@rphillips: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-op 3c3dafd link /test e2e-gcp-op
ci/prow/e2e-aws-scaleup-rhel7 3c3dafd link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

paulfantom pushed a commit to paulfantom/machine-config-operator that referenced this pull request Mar 26, 2020
@kikisdeliveryservice
MCS: remove legacy servers & ports
2a299f1 
legacySecureServer and legacyInsecureServer were added to accomodate the
installer port references when we transitioned the MCS ports from 49500/49501
to 22623/22624. The installer was updated via PR openshift#1180 to use 22623/22624, so
we can now remove the legacy server/port references.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rphillips @openshift-ci-robot