Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30830: Accommodate the case in readiness calculation where readyVGCount is greater than expectedVGCount #612

Merged
merged 1 commit into from
Apr 23, 2024
Merged

OCPBUGS-30830: Accommodate the case in readiness calculation where readyVGCount is greater than expectedVGCount #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controllers/lvmcluster/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func (r *Reconciler) updateLVMClusterStatus(ctx context.Context, instance *lvmv1
instance.Status.State = lvmv1alpha1.LVMStatusFailed
} else if isDegraded {
instance.Status.State = lvmv1alpha1.LVMStatusDegraded
} else if isReady && expectedVGCount == readyVGCount {
} else if isReady && expectedVGCount <= readyVGCount { // readyVGCount can be greater than expectedVGCount in case there are taints on some nodes, e.g. during an upgrade. See https://issues.redhat.com/browse/OCPBUGS-30830 for further details.
instance.Status.State = lvmv1alpha1.LVMStatusReady
instance.Status.Ready = true
}
Expand Down